Skip to content

Commit 6a2fe67

Browse files
authored
fix(tui): keep the xhigh effort color distinct from periwinkle plan mode (#371)
## Requirement or Bug Keep the xhigh effort border distinct from plan mode after #369 made the primary color periwinkle. ## Bug Reproduction Steps On `main`, pick xhigh effort with Shift-Tab, then turn on `/plan`. The prompt border is `#A78BFA` (xhigh) in one case and `#B4B8F8` (plan, periwinkle primary) in the other. The two shades are hard to tell apart. ## Root Cause #369 changed `primary`, and `modePlan` with it, to periwinkle `#B4B8F8`. That moved the plan color close to the existing `effortXHigh` violet. This is a palette fix, not a workaround. ## Code Changes `effortXHigh` changes from `#A78BFA` to `#D58BF0` (dark) and from `#7048B6` to `#8E3AA8` (light). The docs table and the unreleased periwinkle changeset are updated. Contrast: light xhigh on white is 6.32:1, dark xhigh on black is 8.78:1. ## Behavior Changes and Affected Users | Behavior | Before | After | Who relies on the old behavior | Escape hatch | |---|---|---|---|---| | Prompt border at xhigh effort | `#A78BFA` / `#7048B6` | `#D58BF0` / `#8E3AA8` | none (visual only) | custom theme `effortXHigh` | Affected module: `apps/pythinker-code/src/tui/theme/colors.ts`. TUI tests: 2896 passed. ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/PyModel/pythinker-code/blob/main/CONTRIBUTING.md) document. - [ ] I have linked a related issue (external PRs: issue must have a maintainer's `/approve`). - [ ] I have added tests that prove my feature works. (palette value change; existing contrast tests cover it) - [x] The behavior-change table above is complete, and every removed behavior or flipped default is named in the changeset and either has an escape hatch or was explicitly approved by a maintainer in this PR. - [x] Ran `gen-changesets` skill, or this PR needs no changeset. - [x] Ran `gen-docs` skill, or this PR needs no doc update.
1 parent 359f143 commit 6a2fe67

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.changeset/periwinkle-primary.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"@pymodel/pythinker-code": patch
33
---
44

5-
The TUI's main color (links, inline code, selections, focus, plan and shell mode) is now periwinkle instead of cyan in both the dark and light themes.
5+
The TUI's main color (links, inline code, selections, focus, plan and shell mode) is now periwinkle instead of cyan in both the dark and light themes, and the xhigh effort color moves to a pinker violet so it stays distinct from plan mode.

‎apps/pythinker-code/src/tui/theme/colors.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export const darkColors: ColorPalette = {
211211
effortLow: '#B3B3B3',
212212
effortMedium: '#E8E8E8',
213213
effortHigh: '#6FA8DC',
214-
effortXHigh: '#A78BFA',
214+
effortXHigh: '#D58BF0',
215215
effortMax: '#F2C744',
216216

217217
diffAdded: '#4EC87E',
@@ -290,7 +290,7 @@ export const lightColors: ColorPalette = {
290290
effortLow: '#8C8C8C',
291291
effortMedium: '#404040',
292292
effortHigh: '#2E6FB8',
293-
effortXHigh: '#7048B6',
293+
effortXHigh: '#8E3AA8',
294294
effortMax: '#B8860B',
295295

296296
diffAdded: '#0E7A38',

‎docs/customization/themes.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Active `/model` provider and `AskUserQuestion` tabs use `selectionBg` for the ba
3030
| `effortLow` | `#B3B3B3` | `#8C8C8C` | Low thinking effort; colors the prompt-area border. |
3131
| `effortMedium` | `#E8E8E8` | `#404040` | Medium thinking effort; colors the prompt-area border. |
3232
| `effortHigh` | `#6FA8DC` | `#2E6FB8` | High thinking effort; colors the prompt-area border. |
33-
| `effortXHigh` | `#A78BFA` | `#7048B6` | Extra-high thinking effort; colors the prompt-area border. |
33+
| `effortXHigh` | `#D58BF0` | `#8E3AA8` | Extra-high thinking effort; colors the prompt-area border. |
3434
| `effortMax` | `#F2C744` | `#B8860B` | Maximum thinking effort; colors the editor effort dot. |
3535
| `diffAdded` | `#4EC87E` | `#0E7A38` | Added lines. |
3636
| `diffRemoved` | `#E85454` | `#B91C1C` | Removed lines. |

0 commit comments

Comments
 (0)