Repository navigation
Commit 6a2fe67
authored
fix(tui): keep the xhigh effort color distinct from periwinkle plan mode (#371)
## Requirement or Bug
Keep the xhigh effort border distinct from plan mode after #369 made the
primary color periwinkle.
## Bug Reproduction Steps
On `main`, pick xhigh effort with Shift-Tab, then turn on `/plan`. The
prompt border is `#A78BFA` (xhigh) in one case and `#B4B8F8` (plan,
periwinkle primary) in the other. The two shades are hard to tell apart.
## Root Cause
#369 changed `primary`, and `modePlan` with it, to periwinkle `#B4B8F8`.
That moved the plan color close to the existing `effortXHigh` violet.
This is a palette fix, not a workaround.
## Code Changes
`effortXHigh` changes from `#A78BFA` to `#D58BF0` (dark) and from
`#7048B6` to `#8E3AA8` (light). The docs table and the unreleased
periwinkle changeset are updated. Contrast: light xhigh on white is
6.32:1, dark xhigh on black is 8.78:1.
## Behavior Changes and Affected Users
| Behavior | Before | After | Who relies on the old behavior | Escape
hatch |
|---|---|---|---|---|
| Prompt border at xhigh effort | `#A78BFA` / `#7048B6` | `#D58BF0` /
`#8E3AA8` | none (visual only) | custom theme `effortXHigh` |
Affected module: `apps/pythinker-code/src/tui/theme/colors.ts`. TUI
tests: 2896 passed.
## Checklist
- [x] I have read the
[CONTRIBUTING](https://github.com/PyModel/pythinker-code/blob/main/CONTRIBUTING.md)
document.
- [ ] I have linked a related issue (external PRs: issue must have a
maintainer's `/approve`).
- [ ] I have added tests that prove my feature works. (palette value
change; existing contrast tests cover it)
- [x] The behavior-change table above is complete, and every removed
behavior or flipped default is named in the changeset and either has an
escape hatch or was explicitly approved by a maintainer in this PR.
- [x] Ran `gen-changesets` skill, or this PR needs no changeset.
- [x] Ran `gen-docs` skill, or this PR needs no doc update.1 parent 359f143 commit 6a2fe67
3 files changed
Lines changed: 4 additions & 4 deletions
File tree
- .changeset
- apps/pythinker-code/src/tui/theme
- docs/customization
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
| 214 | + | |
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| |||
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
293 | | - | |
| 293 | + | |
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
0 commit comments