Skip to content

fix(ci): retain gitleaks findings for fourteen days - #6

Merged
kert114 merged 1 commit into
mainfrom
ci/gitleaks-artifact-retention
Nov 16, 2026
Merged

kert114 merged 1 commit into
mainfrom
ci/gitleaks-artifact-retention

Conversation

@kert114

@kert114 kert114 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The shared secret-scanning workflow retains gitleaks-findings for 30 days. Platform and pipelines inherit that retention through their immutable workflow pins, so their repository workflow retention caps do not cover these reports.

Reduce the shared upload retention to 14 days. Scanning rules, redaction, failure handling and run-log retention stay unchanged. Consumer pins will be updated separately after a person lands this PR.

Refs https://github.com/60xAI/ai-brain-platform/issues/4451 and https://linear.app/60x/issue/DEV-2875.

Verification

  • All three existing scanner regression tests passed with pinned gitleaks 8.30.1, using only synthetic credentials in temporary repositories.
  • Actionlint passed with the existing Blacksmith label configuration and ShellCheck disabled.
  • The diff changes only the retention value on the existing gitleaks-findings upload.

Risk and rollback

  • Door: two-way, revert the retention value to restore the prior policy for new artifacts.
  • Affects: secret-scan path/rule report availability after day 14 in consumers that adopt the new pin.
  • Rollback: revert the commit and update consuming pins if already adopted. Reports that expire cannot be restored by a code revert.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Chores
    • Gitleaks findings are now retained for 14 days instead of 30.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Gitleaks findings artifact retention period changes from 30 days to 14 days.

Changes: Gitleaks Artifact Retention

Layer / File(s) Summary
Update artifact retention
.github/workflows/gitleaks.yml
The workflow changes the findings artifact retention period from 30 days to 14 days.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: fergus-mw

Merge Risk: Minimal · up to 1e158

This change shortens how long the secret-scan findings report is kept from 30 to 14 days. Scanning and failure behavior are unchanged. Consumers adopt the change only when they update their pins, so there is no merge-blocking risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: the gitleaks findings artifact retention is extended to fourteen days in the CI workflow. The raw summary says retention changes from 30 days to 14 days, which is a r…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the gitleaks findings artifact retention is extended to fourteen days in the CI workflow. The raw summary says retention changes from 30 days to 14 days, which is a reduction, not an extension. The title therefore names the right file area and artifact but states the direction of change as retention for fourteen days, which is accurate in its wording. The title is specific, uses the conventional prefix, and does not include file lists or vague terms. The one point of concern is that the title does not indicate that retention is shortened from 30 days, but it does name the new value clearly.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Errors were encountered while retrieving linked issues.

Errors: 1

  • LINEAR integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: a2fcfe26-453a-417c-815a-068ab30f35cd
Commits

Reviewing files that changed from the base of the PR and between 1f2ab28 and 1e15862.

Files selected for processing: 1

  • .github/workflows/gitleaks.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@kert114 kert114 added the two-way door Cheap to reverse and restore the previous behavior. label Nov 16, 2026
@kert114
kert114 merged commit 199fa8d into main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

two-way door Cheap to reverse and restore the previous behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant