Repository navigation
Ignore a cookie Path with control characters - #57
Merged
FlorianRappl merged 2 commits intoNov 4, 2026
Merged
FlorianRappl merged 2 commits into
FlorianRappl merged 2 commits into
Conversation
RFC 6265 does not allow control characters in a path value. A tab or newline in the path was written unescaped into the Netscape cookie file, so a single cookie could add lines for other domains, which were loaded on the next start. The attribute is now ignored and the default path is used, as for other invalid paths.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for #54.
A tab or newline in
Pathwas written unescaped into the Netscape cookie file. So one cookie could add lines for other domains, which were loaded on the next start. A single tab made the file unreadable.TryParsePathnow applies the parser's existingInvalidCharscheck (RFC 6265 path-value).Test: the injected line doesn't come back after a reload.
🤖 Generated with Claude Code