Repository navigation
Release 1.2.0 - #154
Merged
Merged
Release 1.2.0#154
Conversation
Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>
…tions-job Synchronize cross-origin message assertions
JsModuleLoader fetched only http and https modules through AngleSharp's
IResourceLoader. Every other URL went to Jint's DefaultModuleLoader, which
reads it from the local disk, so any page could import file: URLs (through
an import map, a direct specifier or import()) and read or run local files.
Bytes modules (with { type: 'bytes' }) always took Jint's file path.
- LoadModuleContents and LoadModuleContentsAsBytes both go through the
resource loader for every scheme, so the registered requesters decide
what a page can reach; a host that wants local modules registers a
requester for file:
- A missing response is reported as an error instead of a
NullReferenceException
- Module resolution is unchanged
- Tests: a page at https://example.com/ cannot read a temporary local file
as a JSON, JavaScript or bytes module, through any of the three ways in
Fixes #150
Load every module through the resource loader
|
|
Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>
Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>
Allow more time for cross-origin message delivery tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
This pull request prepares for the 1.2.0 release with dependency and documentation updates. Most importantly, these changes improve script compatibility and fix missing and wrongly implemented DOM APIs.
Important: Requires AngleSharp 1.10.0 to be released first.