Repository navigation
Add max_tasks_per_child param to parallel - #961
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
max_tasks_per_child=1ensures every item inProcessPoolExecutorruns in a fresh process.Currently, a pool reuses its workers, so whatever one item changes in the worker's process is still there for the next item; e.g. a module it imported, an attribute it set on a class,
os.environ, a global cache. Anyfthat relies on starting clean gets different results depending on which items share a worker. For example, in nbdev, each notebook is one item, so a notebook's imports and monkeypatches leak into the next notebook that the same worker runs, andnbdev-test --savestores outputs built from another notebook's state.The argument needs Python 3.11 and a non-fork start method, so when it is set and
methodisn't,parallelusesforkserver(spawnon Windows).fthen has to be importable, not defined in__main__. Default isNone, so existing calls are unaffected.