Skip to content

Exclude ITPs from legacy ASIM template validation - #15515

Open
adbhogeGit wants to merge 2 commits into
masterfrom
adbhoge-microsoft-separate-qtp-itp-validation
Open

adbhogeGit wants to merge 2 commits into
masterfrom
adbhoge-microsoft-separate-qtp-itp-validation

Conversation

@adbhogeGit

Copy link
Copy Markdown
Contributor

Related to #15463

Proposed Changes

  • Exclude IngestTimeParsers/ YAML from the legacy query-time parser template validator's changed-file selection.
  • Keep ingestion-time validation on its dedicated workflow and preserve trusted-master script loading in the privileged workflow.
  • Add regression coverage for mixed QTP/ITP changes, ITP-only changes, and existing QTP behavior; document the validator boundary.
  • Validation: the documented offline ASIM ingestion-time unittest suite passed (169 tests).

Keep the legacy query-time parser template checks separate from the dedicated ingestion-time validation route, with focused regression coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…atenation in a list'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@adbhogeGit
adbhogeGit requested a balanced review from Copilot October 31, 2026 04:43
@adbhogeGit
adbhogeGit marked this pull request as ready for review October 31, 2026 04:43
@adbhogeGit
adbhogeGit requested review from a team as code owners October 31, 2026 04:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change separating legacy query-time parser validation from ingestion-time validation.

No open issues 🎉

What changed in this PR

This PR separates legacy query-time parser template validation from ingestion-time parser validation, addressing the incorrect routing encountered in #15463.

Changes:

  • Excludes IngestTimeParsers/ YAML files from legacy validation while preserving existing query-time YAML selection.
  • Adds regression tests for mixed changes, ingestion-time-only changes, and existing query-time behavior.
  • Documents the boundary between the legacy validator and the dedicated ingestion-time workflow.
File Description
.script/​tests/​asimParsersTest/​VerifyASimParserTemplate.py Uses the shared query-time file filter and clarifies validator scope.
.script/​tests/​asimParsersTest/​ingestTimeParser/​tests/​test_asim_parser_template_routing.py Adds regression coverage for parser file selection.
.script/​tests/​asimParsersTest/​ingestTimeParser/​README.md Documents the separate validation paths.
.script/​tests/​asimParsersTest/​asim_parser_file_utils.py Adds the ingestion-time directory exclusion, supporting both path separators.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants