Repository navigation
Exclude ITPs from legacy ASIM template validation - #15515
Open
adbhogeGit wants to merge 2 commits into
Open
adbhogeGit wants to merge 2 commits into
adbhogeGit wants to merge 2 commits into
Conversation
Keep the legacy query-time parser template checks separate from the dedicated ingestion-time validation route, with focused regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…atenation in a list' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change separating legacy query-time parser validation from ingestion-time validation.
No open issues 🎉
What changed in this PR
This PR separates legacy query-time parser template validation from ingestion-time parser validation, addressing the incorrect routing encountered in #15463.
Changes:
- Excludes
IngestTimeParsers/YAML files from legacy validation while preserving existing query-time YAML selection. - Adds regression tests for mixed changes, ingestion-time-only changes, and existing query-time behavior.
- Documents the boundary between the legacy validator and the dedicated ingestion-time workflow.
| File | Description |
|---|---|
.script/tests/asimParsersTest/VerifyASimParserTemplate.py |
Uses the shared query-time file filter and clarifies validator scope. |
.script/tests/asimParsersTest/ingestTimeParser/tests/test_asim_parser_template_routing.py |
Adds regression coverage for parser file selection. |
.script/tests/asimParsersTest/ingestTimeParser/README.md |
Documents the separate validation paths. |
.script/tests/asimParsersTest/asim_parser_file_utils.py |
Adds the ingestion-time directory exclusion, supporting both path separators. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15463
Proposed Changes
IngestTimeParsers/YAML from the legacy query-time parser template validator's changed-file selection.