Skip to content

[ASIM] Preserve source id in fixture and optional raw replay schemas - #15516

Open
adbhogeGit wants to merge 1 commit into
masterfrom
adbhoge-microsoft-preserve-proofpoint-replay-ids
Open

adbhogeGit wants to merge 1 commit into
masterfrom
adbhoge-microsoft-preserve-proofpoint-replay-ids

Conversation

@adbhogeGit

Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):

  • Preserve the source-defined id column through ASIM ingestion-time fixture schema resolution and optional raw-table replay.
  • Keep existing reserved-column protections unchanged, including _ItemId, _ResourceId, _SubscriptionId, TenantId, and Type.
  • Add regression coverage for inferred, explicit, discovered, and repository schemas and for the real Proofpoint POD MailLog fixture.
  • Extend mocked replay tests to verify id:string and its value across the snapshot, table/DCR schemas, and uploads; document the behavior.

Reason for Change(s):

Version Updated:

  • N/A. No detection, analytic-rule template, parser content, or solution content changes.

Testing Completed:

  • Offline only; no Azure operations or live ingestion. The harness regression uses a fake HTTP session.
  • & 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m unittest discover -s '.script\tests\asimParsersTest\ingestTimeParser\tests' -p 'test_asim_fixture_preparation.py' — passed, 30 tests.
  • & 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m unittest discover -s '.script\tests\asimParsersTest\ingestTimeParser\tests' -p 'test_asim_ingestion_harness.py' — passed, 28 tests.
  • & 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m unittest discover -s '.script\tests\asimParsersTest\ingestTimeParser\tests' -p 'test_asim_*.py' — passed, 168 tests.
  • git --no-pager diff --check — passed.
  • The ::error::Output path must not replace the source fixture. line is expected output from a passing negative CLI test.

Checked that the validations are passing and have addressed any issues that are present:

  • Yes for the documented offline regression suite and diff check. Live Sentinel validation and GitHub CI have not been run locally.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@adbhogeGit
adbhogeGit marked this pull request as ready for review October 31, 2026 04:55
@adbhogeGit
adbhogeGit requested review from a team as code owners October 31, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant