Repository navigation
fix(domains): warn instead of failing when a domain resolves to another IP - #5828
Open
narcisonunez wants to merge 1 commit into
Open
narcisonunez wants to merge 1 commit into
narcisonunez wants to merge 1 commit into
Conversation
…er IP A load balancer, floating IP or NAT in front of the server is a valid setup, so DNS validation now shows a warning instead of an error when the domain doesn't resolve to the server. Closes #5548
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Domains behind a load balancer, floating IP (keepalived) or NAT resolve to an address that isn't the server's, so DNS validation always showed them as invalid even though traffic reaches Traefik.
An IP mismatch is now a yellow warning ("Not pointing to this server" / "IP mismatch") with the resolved and expected IPs in the tooltip, instead of a red error. Domains that don't resolve are still errors. No new settings or schema.
NOTE: I went with this instead of letting users declare the extra addresses (per-server ingress IPs in #5569, per-domain validation modes in #4659). The check is only a hint in the UI and doesn't affect routing or certificates, so a new column, migration and form field felt like too much to maintain for it. A per-server list also wouldn't cover domains on the Dokploy host itself, NAT or split DNS, which this change handles too. If this is something more people ask for it maybe we can go it the full solution
Checklist
canarybranch.Issues related (if applicable)
closes #5548
The PR appears safe to merge; no actionable issues were found.Summary
IP mismatches now produce warnings instead of errors, allowing domains behind load balancers, floating IPs, or NAT.
No actionable issues found. Tests were inspected, not run. Visual capture was blocked by the authenticated page’s database and account setup requirements.
Reviews (1) · Last reviewed commit: "fix(domains): warn instead of failing wh..." · Reviewed by Greptile