Repository navigation
Add shift of the PSF - #122
Conversation
We found that the provided PSF is off-centered by half a pixel (-0.5, -0.5). This implement an external parameter to shift the PSF to the true center of the image. We could also hard code the shift. I don't know what is best here.
|
After some discussion on Slack with @rmandelb, I changed the default to the expected shift of (-0.5, -0.5). If nothing is provided in the config, the PSF will be shifted correctly. |
|
The unit tests are failing because the size is now too large. The thing is, it was a coincidence that the tests passed originally. If we oversample the images, with and without the shif I get the same measured size and it does not match the PSF bright.
|
- Due to the shift of the PSF the returned object from `getPSF` is now a galsim.Transformation we then need to call `.original` to compare to the input image. - The second test on the bright PSF was passing by "luck". With the new shift in place it now fails. I relaxed the requirement on the size to be within 10% to pass. The objects on which the bright PSF is used are not objects used for science so this is fine.
|
New commit:
|
rmandelb
left a comment
There was a problem hiding this comment.
Just some very minor things - looks good
Co-authored-by: Rachel Mandelbaum <rmandelb@andrew.cmu.edu>
Co-authored-by: Rachel Mandelbaum <rmandelb@andrew.cmu.edu>
Co-authored-by: Rachel Mandelbaum <rmandelb@andrew.cmu.edu>
Co-authored-by: Rachel Mandelbaum <rmandelb@andrew.cmu.edu>
Co-authored-by: Rachel Mandelbaum <rmandelb@andrew.cmu.edu>
|
@rmandelb I have applied all your suggested changes |


We found that the provided PSF is off-centered by half a pixel (-0.5, -0.5). This implement an external parameter to shift the PSF to the true center of the image. We could also hard code the shift. I don't know what is best here.