Skip to content

fix(event-display): preserve saved label target types - #1069

Open
dhairyajangir wants to merge 1 commit into
HSF:mainfrom
dhairyajangir:fix/1066-saved-label-target-types
Open

dhairyajangir wants to merge 1 commit into
HSF:mainfrom
dhairyajangir:fix/1066-saved-label-target-types

Conversation

@dhairyajangir

Copy link
Copy Markdown
Contributor

Fixes #1066.

Saved labels include an event-data type, but importing them currently resolves the target by collection name alone. A saved vertex label can therefore overwrite a same-named track label or attach to the wrong scene object. This preserves the saved type, collection and index when finding and registering each label.

An optional EventDataLoader.addSavedLabelToEventObject capability returns the matching UUID and label ID together. Built-in loaders can import both same-named typed collections. Existing name-only loaders and PhoenixLoader subclasses keep their old lookup/registration hooks when the collection name identifies one matching type; ambiguous legacy names are skipped. The regression exercises Save/Load Labels and checks the export registry, scene labels, mesh IDs, menu and re-export, including old-method subclasses. The #1063 missing-index regression remains unchanged.

Validation on df9692b with Node 22.22.1:

  • Both workspace CI-equivalent suites passed with coverage: 459 core tests plus 244 Angular tests (703 passed, seven Angular tests skipped).
  • Core production TypeScript build, full core and Angular ESLint, changed-file Prettier and full Angular Prettier passed.
  • Core documentation coverage passed at 100% (threshold 100%).
  • A Chromium 156 replay passed both missing-type and same-name/two-type cases through real event and label file choosers, scene/menu assertions, and a real phoenix-labels.json download. Save Labels used keyboard activation because external CDN styling was blocked in this local replay; geometry and layout were outside its scope.
  • The test-inclusive tsc --noEmit check still reports TS1192 in unchanged src/tests/helpers/webgl-mock.ts:1; the exact unchanged-main control reports the same error. The production build and test compilation pass.

Codex assisted with the implementation, regression tests and local validation.

@github-actions

Copy link
Copy Markdown

🚀 Preview deployed: http://phoenix-pr-1069.surge.sh

Built from 987a7e6.

This branch was successfully deployed

1 active deployment
pull-request — 987a7e6d Deployed Nov 11, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saved labels can attach to the wrong object type when a collection name is reused

1 participant