Repository navigation
fix(event-display): preserve saved label target types - #1069
Open
dhairyajangir wants to merge 1 commit into
Open
dhairyajangir wants to merge 1 commit into
dhairyajangir wants to merge 1 commit into
Conversation
|
🚀 Preview deployed: http://phoenix-pr-1069.surge.sh Built from 987a7e6. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1066.
Saved labels include an event-data type, but importing them currently resolves the target by collection name alone. A saved vertex label can therefore overwrite a same-named track label or attach to the wrong scene object. This preserves the saved type, collection and index when finding and registering each label.
An optional
EventDataLoader.addSavedLabelToEventObjectcapability returns the matching UUID and label ID together. Built-in loaders can import both same-named typed collections. Existing name-only loaders and PhoenixLoader subclasses keep their old lookup/registration hooks when the collection name identifies one matching type; ambiguous legacy names are skipped. The regression exercises Save/Load Labels and checks the export registry, scene labels, mesh IDs, menu and re-export, including old-method subclasses. The #1063 missing-index regression remains unchanged.Validation on
df9692bwith Node 22.22.1:phoenix-labels.jsondownload. Save Labels used keyboard activation because external CDN styling was blocked in this local replay; geometry and layout were outside its scope.tsc --noEmitcheck still reports TS1192 in unchangedsrc/tests/helpers/webgl-mock.ts:1; the exact unchanged-main control reports the same error. The production build and test compilation pass.Codex assisted with the implementation, regression tests and local validation.