Repository navigation
fix(event-display): extrapolate tracks with zero q/p as straight lines - #1073
Open
G26karthik wants to merge 1 commit into
Open
G26karthik wants to merge 1 commit into
G26karthik wants to merge 1 commit into
Conversation
|
🚀 Preview deployed: http://phoenix-pr-1073.surge.sh Built from e4d410f. |
extrapolateTrackPositions built its start direction from a vector of length p, and p is Number.MAX_VALUE when qop is 0. The vector overflowed, so the direction came out as zero or NaN and the track collapsed to a point or was dropped. Build it from a unit vector, as was done for extrapolateFromLastPosition in HSF#1060.
G26karthik
force-pushed
the
fix-extrapolate-straight-track
branch
from
November 12, 2026 11:10
541adf8 to
e4d410f
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extrapolateTrackPositionsbuilt its start direction from a vector of length p, and p isNumber.MAX_VALUEwhen q/p is 0. The vector overflowed, so the direction came out as zero or NaN and a straight track fromdparamscollapsed to a single point or was dropped. For example, Muons and Electrons loaded withoutLinkedTracksor apdgIdget q = 0 inphoenix-loader.ts, so they were not drawn.The direction now comes from a unit vector, the same change #1060 made in
extrapolateFromLastPosition. Tracks with q/p other than 0 give the same points as before.Testing
jest --config configs/jest.conf.js src/tests/helpers/rk-helper.test.ts[0, 0, 0]points; it now expects a straight line along the start direction.