Skip to content

Remove search_data and only use search_document so all submission search works the same - #5047

Open
frjo wants to merge 12 commits into
mainfrom
enhancement/improve-search-require-postgres
Open

frjo wants to merge 12 commits into
mainfrom
enhancement/improve-search-require-postgres

Conversation

@frjo

@frjo frjo commented Oct 27, 2026

Copy link
Copy Markdown
Member

Also add GIN index on form_data for faster category search/filtering.

The submission all view used the new search_document already, this PR implement it for all table2 views as well so no all submission search works the same.

Fixes a bug where older submission did not have a search_document to index, this PR adds a migration that generate this.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter labels Oct 27, 2026
@frjo
frjo requested a review from wes-otf October 27, 2026 08:35
@frjo
frjo force-pushed the enhancement/improve-search-require-postgres branch from 4243cfe to e0f5953 Compare November 2, 2026 12:40
@frjo
frjo force-pushed the enhancement/improve-search-require-postgres branch from 85b3d49 to 115de5c Compare November 5, 2026 18:08
…Make the code handle sumbissions with missing email or full_name.
@wes-otf

wes-otf commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This is super interesting - staff had mentioned that some of the search results didn't seem to yield all applicants that would match the criteria, do you think this could be the reason for that?

@frjo

frjo commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

Yes, that is a likely cause. Hopefully it will be fixed with this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants