Repository navigation
docs: add DeepWiki navigation and clarify README guidance - #545
Conversation
Dong1017
left a comment
There was a problem hiding this comment.
PR review verdict — DO NOT PASS
Reviewed the full README-only diff for #545 from base 9466bc8d910c9fef55d4a9e23ee1a82950280c30 to head fc7fc2828e8e2d4e12ffc96592436cdd134be591. The review record shows no formal approval on this head and no outstanding changes request. The blockers below are about evidence for the new wording, not a request to rerun benchmarks.
README.md:100— The DeepSeek row now identifies the three unchanged values as medians of six run-level means. I read #353 and confirmed the workload and 25 ms/token target, but the available issue text does not include the linked historical calibration comment or its six-run aggregation. The issue's current two-start protocol does not establish how those historical numbers were calculated. Cite the historical table or artifact that shows the aggregation, or keep the previous, less specific wording.README.md:150— The MiniCPM-o row changes “quality unqualified” to “formal speech quality checks were not run.” Those are not equivalent: checks could have run without qualifying the configuration. Point to the passage in the pinned same-card report that records the checks as not run for this configuration, or retain “quality unqualified.”
No runtime code changed. I did not run the dashboard, check live links, or verify CI. This comment does not approve the PR; I’ll re-read after the author pushes.
Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model gpt-6.2-sol).
zengchuang-hw
left a comment
There was a problem hiding this comment.
NO PASS
首次独立检视:9466bc8d910c9fef55d4a9e23ee1a82950280c30…fc7fc2828e8e2d4e12ffc96592436cdd134be591。只改动 README.md,无上一轮意见。
批准前请补齐两点:
- PR 说明仍是模板,
Refs #<issue-number>没有指向实际 Issue。请填入已有的文档 Issue,简述本次范围和实际核查结果;不用为这次小改动另做实验。 README.md:5新增的 DeepWiki 是顶栏入口。我未能从公开访问核实它已经显示 InferRSI 的文档,不能据此断言链接已坏。请确认未登录访客能打开正确的项目页;若尚未索引,先移除这条入口。
正文改写与所引证据一致:Dashboard 默认写入输入目录;DeepSeek 三档数值是六次运行均值的中位数;LFM3 在各自测试温度下对比保留波形;MiniCPM 正式语音质量门未在所测配置上运行。未重跑 CLI 或性能实验。
|
首次完整检视: 关于所引证据(独立核对):
合并前请补齐:
其他已核:
|
Signed-off-by: Inference1 <3617237115@qq.com>
fc7fc28 to
007e65b
Compare
zengchuang-hw
left a comment
There was a problem hiding this comment.
NO PASS
增量复核:fc7fc2828e8e2d4e12ffc96592436cdd134be591 → 007e65b87a770b60457297031b4480dac5b8325c,上一轮检视。两个提交指向同一文件树,README 内容和上一轮验证过的正文一致。
PR 说明已补齐改动范围、数据来源及作者的 DeepWiki 无登录 HTTP 200 验证记录;但说明仍明确写着本轮 governing Issue 待确认。#531 已关闭,对应的是 #533 的上一轮文档刷新,并未记录本次新增导航的范围。批准前请链接本轮适用的 Issue,或记录维护者明确确认的跟进范围。
已比较精确版本及 README,复核了 #531 的范围。DeepWiki 的公开访问目前只有作者记录,本轮未独立复测;未重跑 CLI 或性能实验。仓库 About 设置不是本 PR 的文件改动,也不是本轮检视的前置项。
|
@zuiho-kai @zengchuang-hw Would you please review this |
|
增量检视: PR 说明已从模板补成实际范围、数据来源链接和 DeepWiki 未登录 HTTP 200 的核验记录,knowledge 声明也改为 Not applicable。上次指出的占位符问题已解决。 仍待处理,本轮不 Approve:
未重跑基准或 CLI;DeepWiki 公开访问与 DeepSeek 六轮中位出处仍以上次独立核对为准,本轮未再复测。 |
Point directly to the six-run DeepSeek calibration and the quality status of the headline MiniCPM-o configuration. Format the dashboard instructions without trailing whitespace. Agent-assisted-by: Codex (author) Signed-off-by: Inference1 <3617237115@qq.com>
zengchuang-hw
left a comment
There was a problem hiding this comment.
NO PASS
增量检视:007e65b87a770b60457297031b4480dac5b8325c → 76342a1ae2e34ac417ca63e0daf0f267f2342180(1 个提交、1 个 README)。上轮检视。独立核对了两个版本:仪表盘段落已去掉尾部空格,DeepSeek 仍指向同一六轮 TPOT 表,MiniCPM-o 已明确到 track_s_fast_r11,并直链质量状态。没有发现新内容错误。
批准前待补: 新建的 #557 已把本次 README 范围列出来,包括 DeepWiki;这解决了没有跟踪 Issue 的问题,但 Issue 仍明确等待维护者确认。请在批准范围后用普通 Refs #557 关联(不要自动关单),并把 PR 正文里的仓库 About 设置提议与这个 README-only 变更分开。我未能用外部读取独立打开 DeepWiki,不能据此称链接失效;请把已有的匿名访问证据记录到 #557。未运行 CLI 或读 CI。
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 9466bc8 and head 76342a1.
Reviewed increment 007e65b → 76342a1 (1 commit, README.md only).
Previous blockers on 007e65b are addressed in this increment and in the updated PR body:
- MiniCPM-o now says formal speech quality gates for
track_s_fast_r11were not run, and links to the report's#numerical-and-quality-status. I re-read that section: “Throughput-and-latency 2× gate: FAIL” and “Speech quality gates … Not run fortrack_s_fast_r11,” with a separate development result fortrack_s_fast. - The PR is linked with plain
Refs #557. I confirmed that README-only scope as a maintainer on #557, and recorded the signed-out DeepWiki check there. The About suggestion is no longer in the delivery slice; it is a separate maintainer follow-up in the PR body. - The dashboard sentence no longer has trailing whitespace.
DeepSeek still points at the same six-run median TPOT comment I already checked. CI — knowledge declaration policy is green on this head. The ready/review lane is action_required because this is a fork PR; that is not a README wording issue. I did not rerun the dashboard CLI or benchmarks, and I have not independently re-checked the LFM3 upstream bit-identical wording.
Accuracy/performance comparison evidence is not applicable (documentation-only change, no new experiments). @zengchuang-hw's remaining NO PASS items on this head (maintainer confirmation of #557, DeepWiki evidence on #557, and splitting About out of the delivery slice) are now resolved; that review is COMMENTED, not CHANGES_REQUESTED. Earlier DO NOT PASS / NO PASS reviews were on previous heads.
|
@Dong1017 @zengchuang-hw @amy-why-3459, could you independently re-review the README-only diff from
Please record your verdict as a formal GitHub review of this head using the repository's review format. Posted by Codex on behalf of Inference1. |
zengchuang-hw
left a comment
There was a problem hiding this comment.
NO PASS
证据增量复审:76342a1ae2e34ac417ca63e0daf0f267f2342180 未变。上一轮的范围阻塞已解决:#557 已记录范围确认,PR 正文已用 Refs #557 关联,并移除了 About 设置建议。README 其余文字和来源的核对结论不变。
仅剩已接受的匿名访问验收项。 #557 记录了作者以匿名 GET 看到项目正文的结果;我用独立网页读取和匿名 HTTPS 请求复核时,分别遇到工具无法访问及连接超时。这不是链接失效的证据,也不否定作者的记录。请在 #557 补一份可独立核对的匿名访问留存(例如移除敏感头后保留请求方式、最终 URL、HTTP 状态、时间及项目页面标题),或提供可复核的公开结果。没有额外的措辞或代码阻塞,未运行 CLI 或查看 CI。
Dong1017
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 9466bc8 and head 76342a1 (README.md only, full diff seen).
My earlier DO NOT PASS items (on fc7fc28) are resolved:
- DeepSeek row (
README.md:~103): it now says the values are medians of the six run-level mean TPOT measurements at C1/C4/C16. It links the historical #353 calibration comment directly. amy-why-3459 read that comment and confirmed the 39.28 / 44.07 / 56.86 values and the six-run aggregation, and all three values are above the 25 ms/token target. - MiniCPM-o row (
README.md:~153): "quality unqualified" is replaced by "The overall throughput and latency target was not met. Formal speech quality gates fortrack_s_fast_r11were not run." It links the pinned#numerical-and-quality-statussection. The wording is scoped to that profile, so it does not read as "no quality data at all". amy re-read that section and found it consistent.
Scope and governance:
- The PR uses plain
Refs #557. #557 records the README-only scope, and that scope was confirmed by me as Dong-bot (authorized delegate) and by amy-why-3459. Repository About metadata is outside the diff and the PR scope. - The other README edits match #557's accepted clauses. They are the DeepWiki nav link, the dashboard text (
inferrsi dashboard --input .writesdashboard.htmlin that directory, then open it in a browser), the LFM3 per-temperature bit-for-bit wording, and the Contributing clause (required checks, two independent approvals, issue owner accepts or reopens). - The diff touches no runtime code, so no benchmark or accuracy comparison applies.
Formal review state on this head: amy-why-3459 APPROVED. zengchuang-hw's remaining item is a COMMENTED "NO PASS" on this head. It asks only for an independently checkable anonymous-access record for DeepWiki. They state there are no wording or code blockers. #557 records the date, method (anonymous curl GET), HTTP 200 and page title, and amy independently opened the page signed out. I treat that as sufficient for a README nav link. The link is also easy to remove if DeepWiki ever stops serving it.
Not verified: I did not run the dashboard CLI, open DeepWiki, or re-read the upstream LFM3 and MiniCPM-o passages. The LFM3 and DeepWiki points rest on the author's record in #557 and amy's check. I did not check CI. amy reports the knowledge-declaration check is green and the review lane is action_required because this is a fork PR.
Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model claude-sonnet-5-5).
|
@zengchuang-hw,已按你在
Codex 代表 Inference1 发布。 |
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
同一提交 76342a1ae2e34ac417ca63e0daf0f267f2342180 的证据增量复审,无新代码;回应本次请求。上轮剩余的 DeepWiki 留存已补齐。独立对照了 README 和匿名 GET 留存:请求排除了认证和 Cookie,README 目标与记录的最终 URL 一致;Overview 和 Getting Started 均记录 HTTP 200、对应项目的标题、时间与响应体哈希,并给出了复核命令。这是对留存及其与改动一致性的核对,不声称我这边重新取得了 HTTP 200 或重新计算了响应体哈希。
#557 已确认 README-only 范围;仪表盘说明和三项指标来源沿用前轮源码与资料核对。未重新运行 dashboard CLI 或查看 CI。本批准仅针对该 README 改动,不替代 Issue 最终验收或合入判断。
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 9466bc8d910c9fef55d4a9e23ee1a82950280c30 and head 76342a1ae2e34ac417ca63e0daf0f267f2342180.
Technical / third-party verify only (cursor App collaborator permission none — not write+ eligible / dual-tip / merge-ready).
Checked
- README-only: DeepWiki nav link; dashboard open wording; DeepSeek TPOT / LFM3 / MiniCPM evidence wording; contributing merge bar phrasing.
- Tip already has Dong1017 + amy + zeng Approves after #557 README-only scope confirm; declarations / knowledge-model-policy green on tip.
Governing Issue and delivery slice
Refs #557
This README-only follow-up builds on the documentation refresh in #533 for #531. The confirmed scope covers DeepWiki navigation, dashboard export instructions, benchmark evidence, and contribution guidance. Maintainer scope decision
Changed artifacts and evidence
InferMatrixLab/InferRSIOverview with links to Getting Started and the module layout. Project documentationdashboard.htmlin the recorded run directory and open it in a browser. A local smoke test using a minimal run record generated the HTML in the input directory withinferrsi dashboard --input .. Dashboard guidetrack_s_fast_r11. It separately reports development quality measurements fortrack_s_fast. The README names the exact profile and links to the quality table. Same-card resultsKnowledge authorship declaration
Not applicable under
knowledge-model-policy. The diff touches onlyREADME.md. Codex assisted the review follow-up and is credited in its commit trailer.Checks and dependencies
git diff --checkand the repository's PR-reference check passed.