Repository navigation
More GHA fixes - #6775
Merged
Merged
More GHA fixes#6775
Conversation
erikd
requested
a balanced review from Copilot
and removed request for
a team
November 18, 2026 02:41
There was a problem hiding this comment.
🟡 Changes recommended
Package input remains vulnerable to command injection in the write-enabled job, and version validation rejects the current three-component release versions.
2 open issues
What changed in this PR
This PR continues hardening the repository’s GitHub Actions workflows by reducing direct expression interpolation in shell scripts and validating release inputs.
Changes:
- Adds version and branch validation before Herald release steps.
- Parses formatting paths into a Bash array for quoted argument expansion.
- Passes the build result through an environment variable.
| File | Description |
|---|---|
.github/workflows/stylish-haskell.yml |
Uses shell environment variables and array-based path arguments. |
.github/workflows/herald-release.yml |
Validates release version and branch inputs before checkout. |
.github/workflows/haskell.yml |
Reads the build result from an environment variable. |
Review effort: Balanced
The build-complete job interpolated ${{ needs.build.result }} and the
stylish-haskell job interpolated ${{ env.STYLISH_HASKELL_* }} directly
into their run: scripts. Read them from the environment instead; the
path list is split into an array so it is passed to git as separate
arguments, as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
herald-release interpolates its package, version and base-branch inputs into shell scripts in a job with contents and pull-requests write access. Before checking out, reject a package that is not one of the listed options, a version that is not empty or a plain A.B.C or A.B.C.D version, and a branch that is not a valid branch name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
erikd
force-pushed
the
erikd/yet-more-gha-fixes
branch
from
November 18, 2026 02:59
e6e480e to
9e26673
Compare
carbolymer
approved these changes
Nov 18, 2026
Jimbo4350
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
As per GHA hardening guidelines documented in the
cardano-packagesrepo.Checklist
See Running tests for more details
CHANGELOG.mdfor affected packagecardano-node-chairman,cardano-submit-apiandcardano-testnetinstead need achangelog fragment in
<package>/.changes/, because theirCHANGELOG.mdis generatedfrom fragments at release time. Copy
_TEMPLATE.ymlfrom that directory, or runnix run github:input-output-hk/cardano-dev#herald -- new.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.