Repository navigation
Conversation
Contributor
Author
|
Open question: |
gmlueck
reviewed
Nov 18, 2026
Comment on lines
+11490
to
+11491
|
|
||
| template <typename Property> Property get_property() const; |
Contributor
There was a problem hiding this comment.
Suggested change
| template <typename Property> Property get_property() const; | |
| template <typename Property> Property get_property() const; |
Nit: I think the formatting looks better with no blank line here. I think the formatting pattern is that when a "block" of functions each fit on a single line, there is no need to separate them with a blank line. For example, see the way the constructor overloads are formatted above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the synopsis, wording and code of the
usm_allocatorsection. It follows up on issue #1088, but goes a bit further:Alignmenttemplate parameter from equality comparisonnoexceptexplicitly to the move assignment operatorget_property/has_propertyfunctions to the synopsisIt is accompanied by the following SYCL-CTS PR
Closes #1088
Assisted by Claude