Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only
apiandworkerSandboxaccept extraEnv. The README says to "Set REDIS_TLS=true via extraEnv on each component" to use TLS with Redis, butfileServer,toolCallServerandegressGatewayalso connect to Redis and don't acceptextraEnv, so a Redis that requires TLS can't be used today.This PR adds
extraEnvtofileServer,toolCallServerandegressGateway, rendered after each component's own variables, asapiandworkerSandboxalready do.It also updates the README to list the components that need
REDIS_TLS.Testing
helm templatewithvalues-local.yamlrenders identically before and after this change.extraEnvon each of the three components adds the variable to that component's container only.REDIS_TLS(file-server.ts,tool-call-server.ts,egress-ledger.ts) so this should be the only bit that's missing.