Repository navigation
Conversation
* README by fragments * Adjusted dependency * Changed root menu XML-ID
[REF] Contract Sale: update translations
The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields. This causes the view to crash when a user without the proper permissions tries to access the res.partner form view. The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions. Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
…ce: from contract_sale to contract
[BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-contract_sale/
Currently translated at 100.0% (1 of 1 strings) Translation: contract-19.0/contract-19.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-19-0/contract-19-0-contract_sale/sl/
bm1-phillip
left a comment
There was a problem hiding this comment.
Functional review on Odoo 20.0 Community (nightly 20261110), l10n_de (SKR03), together with #1566. We use this module in production on 19.0.
The 4 tests pass, no warnings from the module in the log. A user who only has the Sales group "User: Own Documents Only" and no accounting rights can read and create contracts and add lines (checked with the ORM as that user). LGTM.
|
Regarding the comment on Lines of B's contracts can still be read directly on |
584a3b6 to
b4744f6
Compare
|
The following commit authors need to sign the Contributor License Agreement: |
#1553