Repository navigation
[18.0][FIX] subscription_oca: default dates evaluated when the server starts - #1583
Open
parabol123654 wants to merge 1 commit into
Open
parabol123654 wants to merge 1 commit into
parabol123654 wants to merge 1 commit into
Conversation
date.today() was called when the module was imported, so new subscriptions got the date the Odoo server was started as their start date and next invoice date. Assisted-by: Claude Opus 5.5
parabol123654
force-pushed
the
18.0-fix-subscription_oca-default-dates
branch
from
November 14, 2026 18:17
6f92443 to
bf62ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaults of
date_startandrecurring_next_dateonsale.subscriptionaredate.today(), which Python evaluates once, when the module is imported. A subscription created days after the server (or worker) started gets that old date as its start date and next invoice date.Steps to reproduce:
The fix uses
fields.Date.context_todayas the default, so the date is computed when the record is created (in the user's timezone, like the other date defaults in Odoo).The new test creates a subscription inside
freeze_time("2030-02-15"). Without the fix it fails with'2026-10-31' != '2030-02-15'.Assisted-by: Claude Opus 5.5