Repository navigation
[18.0][FIX] product_contract_recurrence_in_price: daily recurrence - #1584
Open
parabol123654 wants to merge 1 commit into
Open
parabol123654 wants to merge 1 commit into
parabol123654 wants to merge 1 commit into
Conversation
The invoicing number compared recurring_rule_type with "dayly" while the selection value is "daily", so any contract sale order line invoiced daily raised "Invalid recurring_rule_type." as soon as it had a start date. Assisted-by: Claude Opus 5.5
parabol123654
force-pushed
the
18.0-fix-product_contract_recurrence_in_price-daily
branch
from
November 14, 2026 18:28
ecfd724 to
61b79bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_compute_recurring_invoice_numbertestsrecurring_rule_type == "dayly", but the selection value is"daily", so a daily rule falls through toraise ValidationError(_("Invalid recurring_rule_type.")).The compute runs for every contract line with a start date (the start date defaults to today, and the end date is computed from the duration), so with this module installed a contract sale order line with Invoice Every: Day(s) cannot be set at all; it does not depend on Include Recurrence In Price.
Fix:
"dayly"->"daily".Test
test_compute_amount_daily(January, invoiced every day: 30 invoices, subtotal 300): raisesValidationError: Invalid recurring_rule_type.without the fix, passes with it.Assisted-by: Claude Opus 5.5