Skip to content

[18.0][FIX] product_contract_recurrence_in_price: daily recurrence - #1584

Open
parabol123654 wants to merge 1 commit into
OCA:18.0from
parabol123654:18.0-fix-product_contract_recurrence_in_price-daily
Open

parabol123654 wants to merge 1 commit into
OCA:18.0from
parabol123654:18.0-fix-product_contract_recurrence_in_price-daily

Conversation

@parabol123654

@parabol123654 parabol123654 commented Nov 1, 2026 •

Copy link
Copy Markdown

_compute_recurring_invoice_number tests recurring_rule_type == "dayly", but the selection value is "daily", so a daily rule falls through to raise ValidationError(_("Invalid recurring_rule_type.")).

The compute runs for every contract line with a start date (the start date defaults to today, and the end date is computed from the duration), so with this module installed a contract sale order line with Invoice Every: Day(s) cannot be set at all; it does not depend on Include Recurrence In Price.

Fix: "dayly" -> "daily".

Test test_compute_amount_daily (January, invoiced every day: 30 invoices, subtotal 300): raises ValidationError: Invalid recurring_rule_type. without the fix, passes with it.

Assisted-by: Claude Opus 5.5

@OCA-git-bot OCA-git-bot added series:18.0 mod:product_contract_recurrence_in_price Module product_contract_recurrence_in_price labels Nov 1, 2026
The invoicing number compared recurring_rule_type with "dayly" while
the selection value is "daily", so any contract sale order line
invoiced daily raised "Invalid recurring_rule_type." as soon as it had
a start date.

Assisted-by: Claude Opus 5.5
@parabol123654
parabol123654 force-pushed the 18.0-fix-product_contract_recurrence_in_price-daily branch from ecfd724 to 61b79bd Compare November 14, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:product_contract_recurrence_in_price Module product_contract_recurrence_in_price series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants