Repository navigation
admin: give the Stale badge its own style - #79
Conversation
Stale reused .badge.test, so it looked the same as Test. It now has an outlined amber style. The test checks the class so it fails if Stale goes back to the test style.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. The Stale badge now has its own 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
aaronbrethorst
left a comment
There was a problem hiding this comment.
Thanks for following up on #66. This fixes the problem: Stale now has its own class, so it no longer looks the same as Test, and the new assertions (toHaveClass('stale') plus not.toHaveClass('test')) would catch a regression. CI is green.
On your questions: outlined amber is the right call. Stale is a warning that the translation needs another look, not an error, so the red error colors would overstate it. As for failed/canceled push statuses sharing the test tone, leave them alone in this PR. That's a separate design choice, and keeping this change narrow is the right move.
Ready to land.



Follow-up to your note on #66. Stale reused .badge.test, so it looked the same as Test. It now has an outlined amber style, and the test checks the class.
Is outlined amber ok, or would you rather it use the red error colors? Also failed and canceled push statuses share the test tone . Should I change those as well or leave them?