Skip to content

admin: give the Stale badge its own style - #79

Merged
aaronbrethorst merged 1 commit into
OneBusAway:mainfrom
nym01:stale-badge-tone
Nov 12, 2026
Merged

aaronbrethorst merged 1 commit into
OneBusAway:mainfrom
nym01:stale-badge-tone

Conversation

@nym01

@nym01 nym01 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to your note on #66. Stale reused .badge.test, so it looked the same as Test. It now has an outlined amber style, and the test checks the class.

Is outlined amber ok, or would you rather it use the red error colors? Also failed and canceled push statuses share the test tone . Should I change those as well or leave them?

Stale reused .badge.test, so it looked the same as Test. It now has an
outlined amber style. The test checks the class so it fails if Stale
goes back to the test style.
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c0ffbc8e-3553-4a84-8983-176eeadb783c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@aaronbrethorst

Copy link
Copy Markdown
Member

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

The Stale badge now has its own .badge.stale class (outlined amber: transparent fill, #6b4b00 text and inset ring), so it no longer renders identically to the Test badge. The test asserts the stale class is present and test is absent, so it would fail if the markup regressed to badge test. Scoped to the one page; no other callers of the test tone are affected.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@aaronbrethorst aaronbrethorst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on #66. This fixes the problem: Stale now has its own class, so it no longer looks the same as Test, and the new assertions (toHaveClass('stale') plus not.toHaveClass('test')) would catch a regression. CI is green.

On your questions: outlined amber is the right call. Stale is a warning that the translation needs another look, not an error, so the red error colors would overstate it. As for failed/canceled push statuses sharing the test tone, leave them alone in this PR. That's a separate design choice, and keeping this change narrow is the right move.

Ready to land.

@aaronbrethorst
aaronbrethorst merged commit 8274f0c into OneBusAway:main Nov 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants