Repository navigation
feat(DocumentQueries): Project and WhereFeature take tolerate, to keep an empty cell where an element lacks the feature - #14
Merged
Conversation
…p an empty cell where an element lacks the feature OpenSysML is making a feature an element row lacks a path error naming the element and the features it does have (QVTS outcome semantics); tolerate = true opts back into the empty cell for sources that mix element kinds. Additive, default false: MINOR. Co-Authored-By: Nicolas Rouquette <nicolas.f.rouquette@jpl.nasa.gov>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…n Project's properties, against a Column path Co-Authored-By: Nicolas Rouquette <nicolas.f.rouquette@jpl.nasa.gov>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSysML is making
Project/WhereFeatureon a feature an element row lacks a path error that names the element and the features it does have (the QVTS outcome semantics: a feature present and empty is a value; a feature the element has none of is a path error). Sources that mix element kinds — the cookbook'sMassTableover parts and connections — need a way to keep today's empty cell, so both operations take an opt-in:Semver: the parameter is additive, but its default changes the meaning of an existing
Project/WhereFeatureover rows that lack the feature (empty cell → path error), which the README classifies as MAJOR. The alternative —default truenow, flipping in a later MAJOR — is open in the review thread for the maintainers to decide.engine-contract.jsonis untouched (no new bound name);.meta.jsonregenerated withscripts/write-project-meta.py.The matching OpenSysML change (executor, cookbook moved to
tolerate = true, design note) is ready on itsfeature/query-feature-outcomesbranch and will re-pin the vendored copy once this merges.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/18ad47adf36f44e9b6824a4472f9678d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/18ad47adf36f44e9b6824a4472f9678d?variant=devin
Requested by: @NicolasRouquette