Repository navigation
Conversation
Refreshing Panorama templates or applications failed when an int field contained a template variable such as $groupID or a multi-type ICMP value such as 13,14. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Template.refreshall()and application refresh raiseValueErrorwhen avartype=intfield is a Panorama template variable (``) or a multi-type ICMP value (13,14for icmp-timestamp).int. Any other text still raisesValueError.Test plan
python -m unittest tests.test_base.TestVariableRefreshes -vTemplate.refreshall(pano)on a template whose HA Group ID is ``default_icmp_type=13,14)Fixes #523
Fixes #560
Made with Cursor