Repository navigation
Conversation
Upgrading 10.1.13 to 10.1.13-h1 crashed because a release with no hotfix was compared as None. The next minor hop also picked 10.2.0-h3 when 10.2.0 was available, and PAN-OS will not load that hotfix until the base image is downloaded. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgrade_to_version('10.1.13-h1')from10.1.13raisedTypeError: '<' not supported between instances of 'NoneType' and 'int'because a base release has no hotfix number. A missing hotfix now ranks as 0, so the base-to-hotfix step is a normal direct upgrade. Fixes Upgrade from standard to hotfix release fails on 1.12.0 #565.10.2.0-h3when10.2.0was also published. PAN-OS then refused the download until the base image was loaded. The lowest patch is still chosen, and on that patch the base image is preferred over a hotfix. Fixes Paloalto firewall upgrade fails with error in upgrade.py #572.Test plan
python -m pytest tests/test_updater.py -q(267 passed)fw.software.upgrade_to_version('10.1.13-h1')from a device on10.1.1310.1.xtoward11.1.xwhen both10.2.0and10.2.0-h3are listed, and confirm the next hop is10.2.0Made with Cursor