Repository navigation
fix: add the mac notary preflight that #411 did not contain - #414
Merged
Merged
Conversation
#411 described a notarization preflight but its squash contained no workflow change: it committed 888 MB of GitNexus index cache (568 files), six GitNexus skills, and an AGENTS.md/CLAUDE.md rewrite. Revert it, stop tracking the local .gitnexus index, and add the actual check: run `notarytool history` with the release credentials before electron-builder, so an expired Apple agreement (HTTP 403) fails in seconds with a clear message instead of after packaging and signing.
WalkthroughWarning Review details and warnings were omitted to fit the comment limit. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement or Bug
#411 says it adds a macOS notarization preflight. The merged commit has no workflow change. It added 888 MB of GitNexus index cache to the repository instead. Refs #412.
Bug Reproduction Steps
git show --stat 1b51dc42d. The commit has 568.gitnexus/**files (parse caches,meta.json,gitnexus.json), six.agents/skills/gitnexus-*files, and rewrites ofAGENTS.mdandCLAUDE.md.grep -n notarytool .github/workflows/desktop-release.yml. There is no preflight step.HTTP status code: 403. A required agreement is missing or has expired.Root Cause
The #411 branch committed a local GitNexus index run, and the intended workflow change never landed.
.gitnexus/is not in.gitignore, so anygitnexus analyzein a checkout can stage the index again.The 403 itself is Apple account state: the Developer Program or App Store Connect agreement must be renewed. No code change fixes that. This PR makes the failure fast and explicit.
Code Changes
AGENTS.md/CLAUDE.mdrewrite..gitignore: ignore.gitnexus/.apps/desktop/scripts/check-notary-access.ts: runxcrun notarytool historywith the credentials thatfinalize-mac-artifacts.tsalready uses. On failure it prints Apple's output. On an agreement error it also says that the account holder must accept the agreements.desktop-release.yml: add a "Check Apple notary access" step after "Require signing" and before electron-builder.finalize-mac-artifacts.ts: exportdefaultCommandRunnerso the check can use it.Behavior Changes and Affected Users
notarytool historycall, then packages.gitnexus/indexgitnexus analyzegitnexus analyzeThe preflight runs only in the
macdesktop job. CLI native mac bundles inrelease.ymlalready fail within about 1 minute at notarization, so they are unchanged.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.[skip changeset] Release CI and repository tooling only. Users see no change.