Skip to content

Release 3.0.1 and MCP 2.0.1: linear-time scan masking and #14 review fixes - #15

Merged
elkaix merged 4 commits into
mainfrom
fix/coderabbit-pr14-followups
Nov 4, 2026
Merged

elkaix merged 4 commits into
mainfrom
fix/coderabbit-pr14-followups

Conversation

@elkaix

@elkaix elkaix commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What

  • scan stall fix: 3.0.0's comment masking was quadratic on some files. 500 KB of unclosed /* or <!-- lines took 30–60 s, and a long CSS line full of // took 10 s. The searches are now memoized and finish in milliseconds; a test guards it.
  • Masking accuracy:
    • One-line regex literals (including after return) and unquoted CSS url(…) count as text.
    • Comments inside template ${…} are masked.
    • JSX and Vue slashes ({b} />, {{a}}/{{b}}) no longer start a regex.
  • CodeRabbit findings on Release 3.0.0 and MCP 2.0.0: MSW 3, Node 22 floor, scan robustness #14:
    • npm 6 lockfiles are read.
    • Checks gated by a config flag are no longer counted as unknown.
    • Nested cn() calls are handled.
    • The MCP smoke test packs into a temp directory.
    • Doc corrections for msw, playwright, tailwind and the README.

Findings left unfixed, with reasons:

  • Indented top-level vi.hoisted: needs brace tracking.
  • Narrowing the MSW connection / onUnhandledRequest checks: would miss values stored in variables first.
  • An apostrophe in JSX text: needs a JSX parser; affects only that line.
  • Ancestor-lockfile workspaces check: matches how Node resolves packages upward.

See CHANGELOG.md → 3.0.1.

Verification

Root tests 27/27, lint 0 errors, both package smoke tests pass, MCP 14/14. Every new test failed on the old code. An independent review found three masking regressions in the first pass; all are fixed and tested.

Summary by CodeRabbit

  • Bug Fixes

    • Improved scanning of nested Tailwind class expressions, comment masking across JavaScript and CSS syntax, and npm lockfile version detection.
    • Corrected how checks disabled by configuration are counted.
    • Improved package smoke-test handling and updated responsive breakpoint guidance.
  • Documentation

    • Clarified scan version-gating and file inclusion rules, and updated guidance for MSW, Playwright, and Tailwind.
  • Release

    • Released version 3.0.1.



Masking cached its searches, so hostile files no longer take 10-60 s.
Regex literals, CSS url() and template expressions are handled; npm 6
lockfiles resolve; config-gated checks no longer count as unknown. Doc
corrections for msw, playwright, tailwind and the README.
A slash after } (JSX {b} />, {a}/{b}, Vue {{a}}/{{b}}) is no longer read
as a regex, a regex cannot end on a // or /* opener, and url(/path) is
skipped in Vue, Svelte, Astro and HTML style blocks too. Found by an
independent review: each case leaked a comment past the masker.
return /[/*]/ hid every line up to the next */ in the file.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The 3.0.1 update changes scan parsing and version checks, adjusts MCP package smoke-test packaging, and revises MSW, Playwright, and Tailwind references. It also updates package versions and the changelog.

Changes: Scan behavior and release

Layer / File(s) Summary
Comment masking and syntax handling
bin/react-frontend-skills.mjs, test/cli.test.mjs
maskComments now skips recognized regex literals, template expressions, and unquoted CSS URLs. It caches delimiter searches. Tests cover these syntax cases and large malformed inputs.
Scan version and check selection
bin/react-frontend-skills.mjs, bin/checks.mjs, README.md, test/cli.test.mjs
Version detection adds npm lockfile v1 root dependency lookup. Checks excluded by onlyIf no longer affect version eligibility counters. Tailwind matching handles nested calls. README guidance and tests cover the updated scan behavior.
3.0.1 release metadata
package.json, CHANGELOG.md
The root package version changes to 3.0.1. The changelog adds the release entry and comparison link.

MCP package smoke test

Layer / File(s) Summary
Temporary package installation
mcp/package.json, mcp/scripts/package-smoke.mjs
The smoke test packs the package into its temporary installation directory and uses npm’s reported tarball filename. It no longer removes a tarball from the package root. The MCP package version changes to 2.0.1.

Skill reference guidance

Layer / File(s) Summary
MSW, Playwright, and Tailwind guidance
skills/msw/references/*, skills/playwright/references/*, skills/tailwind/references/resp-custom-breakpoints.md
MSW references update Node.js and TypeScript configuration guidance. Playwright references update artifact patterns and project selection examples. Tailwind guidance clarifies breakpoint equivalence under different themes.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Low · up to 22934

The scan improvements are mergeable with awareness of a narrow regression: a dangling Next.js configuration symlink can abort scanning even when the associated check is ineligible. Catching configuration filesystem errors would remove this risk.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@elkaix
elkaix merged commit dfc8ff6 into main Nov 4, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant