Repository navigation
Release 3.0.1 and MCP 2.0.1: linear-time scan masking and #14 review fixes - #15
Conversation
A slash after } (JSX {b} />, {a}/{b}, Vue {{a}}/{{b}}) is no longer read
as a regex, a regex cannot end on a // or /* opener, and url(/path) is
skipped in Vue, Svelte, Astro and HTML style blocks too. Found by an
independent review: each case leaked a comment past the masker.
return /[/*]/ hid every line up to the next */ in the file.
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
What
scanstall fix: 3.0.0's comment masking was quadratic on some files. 500 KB of unclosed/*or<!--lines took 30–60 s, and a long CSS line full of//took 10 s. The searches are now memoized and finish in milliseconds; a test guards it.return) and unquoted CSSurl(…)count as text.${…}are masked.{b} />,{{a}}/{{b}}) no longer start a regex.cn()calls are handled.Findings left unfixed, with reasons:
vi.hoisted: needs brace tracking.connection/onUnhandledRequestchecks: would miss values stored in variables first.workspacescheck: matches how Node resolves packages upward.See
CHANGELOG.md→ 3.0.1.Verification
Root tests 27/27, lint 0 errors, both package smoke tests pass, MCP 14/14. Every new test failed on the old code. An independent review found three masking regressions in the first pass; all are fixed and tested.
Summary by CodeRabbit
Bug Fixes
Documentation
Release