Repository navigation
Conversation
The bit-banged I2C spent ~200 instructions per bit in an out-of-line delay, about 15x slower than the stock firmware. Every frame took long enough that the GUI was sluggish and short button presses were missed, since the buttons are polled once per GUI frame. Use the stock edge timing with 3 NOPs of margin. With the faster bus the slide animations are smooth, so OLED_TRANSITIONS_INSTANT is no longer needed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Laggy interface and missed button presses on HS-01.
See #2251 (comment)
@radosek as discussed in #2251, could you test it on your iron too? Tested on one HS-01 so far.
The whole diff was made with Claude; I tested it on the hardware.