Repository navigation
Conversation
FrontendUserHandler and BackendUserHandler of the json_response extension read the typo3.testing.context attribute and call methods on it unconditionally. Only requests dispatched through FunctionalTestCase::executeFrontendSubRequest() carry that attribute. A frontend request the code under test builds and dispatches itself reaches the same middleware stack without it and fails with: Call to a member function getFrontendUserId() on null Both middlewares now pass such a request on unchanged, since it has no test user to log in and no workspace to force. Resolves: TYPO3#761 Releases: main, 9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrontendUserHandler and BackendUserHandler of the json_response
extension read the typo3.testing.context attribute and call methods on
it unconditionally. Only requests dispatched through
FunctionalTestCase::executeFrontendSubRequest() carry that attribute.
A frontend request the code under test builds and dispatches itself
reaches the same middleware stack without it and fails with:
Call to a member function getFrontendUserId() on null
Both middlewares now pass such a request on unchanged, since it has no
test user to log in and no workspace to force.
Resolves: #761
Releases: main, 9