Repository navigation
feat(cards): style start grid with existing action cards - #1016
Closed
yevheniia0831 wants to merge 4 commits into
Closed
yevheniia0831 wants to merge 4 commits into
yevheniia0831 wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
yevheniia0831
marked this pull request as ready for review
November 17, 2026 09:47
yevheniia0831
requested review from
mhaack and
sharanyavinod
and removed request for
mhaack and
sharanyavinod
November 17, 2026 09:48
Contributor
|
@yevheniia0831 Why are we adding start specific styling into the generic cards block? Consumer should control positioning and styling if needed separately. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Moved the Start-only layout and its regression test to adobe/da-live#1751. The generic cards block and shared nx-action-card stay unchanged. Removed the Nexter changes from this branch. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs adobe/da-live#1637 (cards layout only).
Test URLs:
Summary
Stacked on #978, targeting
toolsas agreed. Keep this draft until the parent merges, then retarget tomain.Reuse the existing cards block and unchanged
nx-action-cardwith the content already authored onstart-copy. Only the.nx-cards.startcontainer gets styling: a centered 664px panel, existing spacing/radius/shadow tokens, two columns on desktop and one on narrow screens.The current AEM Scheduler, Traverse, Bulk Operations and Translate cards retain their authored text, icons, links, default Open actions and Learn more menus. No content edit or new authoring format is needed.
Removed the earlier custom action-card variant, icon sizing, S/M API, logo/label parsing and style-guide demo. The net diff is two files: consumer CSS and one responsive-layout test. No shared component, parser, greeting, Add Site, background, routing or published-document changes.
Validation
start-copychecked in Chrome without local source/content overrides: all four authored cards render as defaultnx-action-cardinstances, 664px/two-column grid at 1280px, 375px/one-column grid without horizontal overflow at 375px, unchanged action URLs and visible keyboard focus. No page errors.color-schemein the test browser. No new theme or size mechanism.