Skip to content

feat(cards): style start grid with existing action cards - #1016

Closed
yevheniia0831 wants to merge 4 commits into
toolsfrom
start-cards
Closed

yevheniia0831 wants to merge 4 commits into
toolsfrom
start-cards

Conversation

@yevheniia0831

@yevheniia0831 yevheniia0831 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Refs adobe/da-live#1637 (cards layout only).

Test URLs:

Summary

Stacked on #978, targeting tools as agreed. Keep this draft until the parent merges, then retarget to main.

Reuse the existing cards block and unchanged nx-action-card with the content already authored on start-copy. Only the .nx-cards.start container gets styling: a centered 664px panel, existing spacing/radius/shadow tokens, two columns on desktop and one on narrow screens.

The current AEM Scheduler, Traverse, Bulk Operations and Translate cards retain their authored text, icons, links, default Open actions and Learn more menus. No content edit or new authoring format is needed.

Removed the earlier custom action-card variant, icon sizing, S/M API, logo/label parsing and style-guide demo. The net diff is two files: consumer CSS and one responsive-layout test. No shared component, parser, greeting, Add Site, background, routing or published-document changes.

Validation

  • Passed, 71 tests across six files:
    npx --no-install wtr --config ./nx2/test/wtr.config.mjs 'nx2/test/unit/blocks/{cards,cards-filter}/**/*.test.js' 'nx2/test/unit/blocks/shared/{action-card,card-search,icons}.test.js' 'nx2/test/unit/nx/blocks/site-apps/*.test.js' --node-resolve --port=2057
  • Passed:
    npx --no-install eslint nx2/test/unit/blocks/cards/cards.test.js
    npx --no-install stylelint nx2/blocks/cards/cards.css
    git diff --check
  • Actual published start-copy checked in Chrome without local source/content overrides: all four authored cards render as default nx-action-card instances, 664px/two-column grid at 1280px, 375px/one-column grid without horizontal overflow at 375px, unchanged action URLs and visible keyboard focus. No page errors.
  • Light/dark token rendering checked by setting color-scheme in the test browser. No new theme or size mechanism.
  • Full suites and signed-in tool navigation were not run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aem-code-sync

aem-code-sync Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@yevheniia0831 yevheniia0831 changed the title feat(cards): add start presentation for onboarding feat(cards): style start grid with existing action cards Nov 17, 2026
@yevheniia0831
yevheniia0831 marked this pull request as ready for review November 17, 2026 09:47
@yevheniia0831 yevheniia0831 self-assigned this Nov 17, 2026
@yevheniia0831
yevheniia0831 requested review from mhaack and sharanyavinod and removed request for mhaack and sharanyavinod November 17, 2026 09:48
@sharanyavinod

Copy link
Copy Markdown
Contributor

@yevheniia0831 Why are we adding start specific styling into the generic cards block? Consumer should control positioning and styling if needed separately.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@yevheniia0831

Copy link
Copy Markdown
Contributor Author

Moved the Start-only layout and its regression test to adobe/da-live#1751. The generic cards block and shared nx-action-card stay unchanged. Removed the Nexter changes from this branch.

This branch was successfully deployed

1 active deployment
start-cards — 77fa3abc Deployed Nov 17, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants