Skip to content

fix(session-ui): remove agent finish checkmark - #59646

Merged
usrnk1 merged 2 commits into
devfrom
remove-agent-checkmark
Oct 27, 2026
Merged

usrnk1 merged 2 commits into
devfrom
remove-agent-checkmark

Conversation

@usrnk1

@usrnk1 usrnk1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove the checkmark icon from successful agent-finish timeline entries.
  • Keep failure and cancellation icons unchanged; successful shell notices remain icon-free.

Verification

  • git diff --check passed.
  • bun typecheck and bun test src/timeline/rows-current.test.ts were attempted from packages/session-ui, but dependencies are not installed.
  • Before/after screenshots could not be captured because the story server cannot start without dependencies.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks correct. Removing the check fallback means a successful finish has no icon, the same as successful shell notices, so the shell-only special case at the call site can go. Failed and cancelled icons and the outcome colour stay as they were. The timeline row tests pass (62/62) and tsc -b passes. I couldn't view it running because session-ui is drawn in the web/desktop app, not the TUI. Could you add before/after screenshots of a finished agent entry?

Public API: unchanged.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commit replaces the old icon-position check with toHaveCount(0) on the finish notice's icon. That fixes the end-to-end test the checkmark removal would otherwise have broken. With the PR, the updated test and the static notices test both pass in Chromium. With the base's row renderer swapped in, the updated test fails with 1 icon found, so the checkmark is gone with this change. Nothing new to raise. Before/after screenshots of a finished agent entry in the app would still help.

Public API: unchanged.

@usrnk1
usrnk1 merged commit 320445a into dev Oct 27, 2026
20 checks passed
@usrnk1
usrnk1 deleted the remove-agent-checkmark branch October 27, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant