Repository navigation
fix(session-ui): remove agent finish checkmark - #59646
Conversation
There was a problem hiding this comment.
The change looks correct. Removing the check fallback means a successful finish has no icon, the same as successful shell notices, so the shell-only special case at the call site can go. Failed and cancelled icons and the outcome colour stay as they were. The timeline row tests pass (62/62) and tsc -b passes. I couldn't view it running because session-ui is drawn in the web/desktop app, not the TUI. Could you add before/after screenshots of a finished agent entry?
Public API: unchanged.
There was a problem hiding this comment.
The new commit replaces the old icon-position check with toHaveCount(0) on the finish notice's icon. That fixes the end-to-end test the checkmark removal would otherwise have broken. With the PR, the updated test and the static notices test both pass in Chromium. With the base's row renderer swapped in, the updated test fails with 1 icon found, so the checkmark is gone with this change. Nothing new to raise. Before/after screenshots of a finished agent entry in the app would still help.
Public API: unchanged.
Summary
Verification
git diff --checkpassed.bun typecheckandbun test src/timeline/rows-current.test.tswere attempted frompackages/session-ui, but dependencies are not installed.