Repository navigation
fix(session-ui): use V2 styling for retry tooltip - #59647
Conversation
There was a problem hiding this comment.
The change looks sound. It switches the retry error tooltip to the existing V2 large appearance and keeps it within 320px (max-w-80) with break-words. Both are supported by the shared Tooltip, and Tailwind already scans session-ui/src, so the classes are generated. tsc -b passes in packages/session-ui. I couldn't run the component tests or view the tooltip here (no Playwright browser available), so I relied on the attached before/after screenshots.
Public API is unchanged.
No concerns.
There was a problem hiding this comment.
The new commit looks sound. The home server row tooltip moves to large with the same 320px wrap as the retry tooltip, and the two copy-button tooltips move to compact. The text-field copy tooltip still opens on copy and closes afterwards under compact. tsc passes in session-ui, ui and app. I didn't view these tooltips here: they're in the web/desktop app, not the TUI.
Public API is unchanged.
One legacy standard tooltip is still in use: the open-file tooltip in packages/session-ui/src/components/session-review.tsx (line 592). The mobile review panel in gui-plugins still renders that component. Since the commit migrates the remaining active tooltips, it's worth converting that one too, or noting why it's left out.
Summary
standardappearance with the V2largeappearance.Screenshots
Before
After
Verification
bun typecheckinpackages/session-uiPLAYWRIGHT_STORIES_PORT=6227 bun run test:components -- component-tests/session-lifecycle.spec.ts --workers=2— 13 passed