Skip to content

fix(session-ui): use V2 styling for retry tooltip - #59647

Merged
usrnk1 merged 3 commits into
devfrom
retry-tooltip
Oct 27, 2026
Merged

usrnk1 merged 3 commits into
devfrom
retry-tooltip

Conversation

@usrnk1

@usrnk1 usrnk1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace the retry error tooltip's legacy standard appearance with the V2 large appearance.
  • Keep the full provider error available on hover, wrapping within a 320px maximum width.

Screenshots

Before

Retry tooltip before: legacy dark appearance

After

Retry tooltip after: V2 appearance

Verification

  • bun typecheck in packages/session-ui
  • PLAYWRIGHT_STORIES_PORT=6227 bun run test:components -- component-tests/session-lifecycle.spec.ts --workers=2 — 13 passed
  • Repository pre-push lint and typechecks passed (existing lint warnings only).
  • Captured and reviewed before/after screenshots. Screenshot files are attached, not committed.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sound. It switches the retry error tooltip to the existing V2 large appearance and keeps it within 320px (max-w-80) with break-words. Both are supported by the shared Tooltip, and Tailwind already scans session-ui/src, so the classes are generated. tsc -b passes in packages/session-ui. I couldn't run the component tests or view the tooltip here (no Playwright browser available), so I relied on the attached before/after screenshots.

Public API is unchanged.

No concerns.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commit looks sound. The home server row tooltip moves to large with the same 320px wrap as the retry tooltip, and the two copy-button tooltips move to compact. The text-field copy tooltip still opens on copy and closes afterwards under compact. tsc passes in session-ui, ui and app. I didn't view these tooltips here: they're in the web/desktop app, not the TUI.

Public API is unchanged.

One legacy standard tooltip is still in use: the open-file tooltip in packages/session-ui/src/components/session-review.tsx (line 592). The mobile review panel in gui-plugins still renders that component. Since the commit migrates the remaining active tooltips, it's worth converting that one too, or noting why it's left out.

@usrnk1
usrnk1 enabled auto-merge (squash) October 27, 2026 17:27
@usrnk1
usrnk1 merged commit 432d870 into dev Oct 27, 2026
20 checks passed
@usrnk1
usrnk1 deleted the retry-tooltip branch October 27, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant