Repository navigation
PostgreSQL: Parse namespaced storage parameters - #2743
Open
LucaCappelletti94 wants to merge 2 commits into
Open
LucaCappelletti94 wants to merge 2 commits into
LucaCappelletti94 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
==========================================
+ Coverage 82.52% 82.54% +0.01%
==========================================
Files 42 42
Lines 35533 35547 +14
Branches 35533 35547 +14
==========================================
+ Hits 29323 29341 +18
+ Misses 2675 2672 -3
+ Partials 3535 3534 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/namespaced-storage-parameters
branch
3 times, most recently
from
October 29, 2026 11:55
e0094dc to
30c3a4a
Compare
LucaCappelletti94
force-pushed
the
upstream/namespaced-storage-parameters
branch
from
October 29, 2026 18:16
30c3a4a to
c37d45e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE TABLE t (a INT) WITH (toast.autovacuum_enabled = false)fails withExpected: =, found: ., as doALTER TABLE t SET (...)andCREATE MATERIALIZED VIEW m WITH (...)with the same parameter. PostgreSQL sets the storage parameters of a table's TOAST table through thetoast.prefix, as documented in https://www.postgresql.org/docs/current/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS.The key of
SqlOption::KeyValueis now anObjectNameparsed as period-separated identifiers, so the namespace is kept and round-trips throughDisplay. This changes the public type of that field. A dot after an option key was a parse error in every dialect, so no dialect flag gates it.