Skip to content

PostgreSQL: Parse namespaced storage parameters - #2743

Open
LucaCappelletti94 wants to merge 2 commits into
mainfrom
upstream/namespaced-storage-parameters
Open

LucaCappelletti94 wants to merge 2 commits into
mainfrom
upstream/namespaced-storage-parameters

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE TABLE t (a INT) WITH (toast.autovacuum_enabled = false) fails with Expected: =, found: ., as do ALTER TABLE t SET (...) and CREATE MATERIALIZED VIEW m WITH (...) with the same parameter. PostgreSQL sets the storage parameters of a table's TOAST table through the toast. prefix, as documented in https://www.postgresql.org/docs/current/sql-createtable.html#SQL-CREATETABLE-STORAGE-PARAMETERS.

The key of SqlOption::KeyValue is now an ObjectName parsed as period-separated identifiers, so the namespace is kept and round-trips through Display. This changes the public type of that field. A dot after an option key was a parse error in every dialect, so no dialect flag gates it.

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.54%. Comparing base (b22bf61) to head (c37d45e).

Files with missing lines Patch % Lines
src/ast/spans.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
+ Coverage   82.52%   82.54%   +0.01%     
==========================================
  Files          42       42              
  Lines       35533    35547      +14     
  Branches    35533    35547      +14     
==========================================
+ Hits        29323    29341      +18     
+ Misses       2675     2672       -3     
+ Partials     3535     3534       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 self-assigned this Oct 27, 2026
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/namespaced-storage-parameters branch 3 times, most recently from e0094dc to 30c3a4a Compare October 29, 2026 11:55
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/namespaced-storage-parameters branch from 30c3a4a to c37d45e Compare October 29, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants