[matrei]

Description

The "Query Aliases and Sorting" section of the GORM for Hibernate 7 guide said that sorting a where query by a property of an association fails when the query has criteria on the same association, and that an explicit alias is required:

// fails because a dynamic alias is used
Pet.where {
    owner.firstName == "Fred"
}.list(sort:"owner.lastName")

With Hibernate 7 this sort works, and WhereQueryWithAssociationSortSpec already expected it to. The section now shows sorting by the association path, notes that the path can go through more than one association, and keeps the explicit alias as an alternative. Its alias example no longer assigns the result of list() to a variable named query.

#16853 fixes the same sorts for Hibernate 5, including paths through more than one association, and updates the Hibernate 5 guide.

Tests

WhereQueryWithAssociationSortSpec for Hibernate 7 checked the sort in one feature, under then: labels saying that an exception is thrown, and with a SQL listing in a comment that no longer matched the query. It now has the same cases as the Hibernate 5 spec in #16853:

• a where query with criteria on club, sorted by club.name ascending and descending, with a sort map, and with chained where calls and fetch: [club: 'join'];
• sorting by club.id, by an explicit alias, and by club.name in a query without criteria on club;
• sorting by two properties of club in a query without criteria on club;
• sorting by team.club.name, a path through more than one association, with criteria on team.club, with criteria on team only, without criteria on either, and through an explicit alias for team.

These pass:

• all tests of grails-data-hibernate7-core;
• aggregateViolations.

[testlens-app]

🚨 TestLens detected 1 failed test 🚨

Test Summary

Tip

Inspect all details with the TestLens CLI: testlens pr 16857

CI / Build Grails-Core (Windows JDK 25 shard 2) > :grails-shell-cli:test

Test	Runs	Flakiness
SpringApplicationRunnerSpec > ROOT OFF prints #failureMode failures to stderr > ROOT OFF prints launch failures to stderr	❌	1% 🟡

🏷️ Commit: 8b6e96e
▶️ Tests: 91441 executed
⚪️ Checks: 94/94 completed

Test Failures

SpringApplicationRunnerSpec > ROOT OFF prints #failureMode failures to stderr > ROOT OFF prints launch failures to stderr (:grails-shell-cli:test in CI / Build Grails-Core (Windows JDK 25 shard 2))

Condition failed with Exception:

runFixture(failureMode, false) == 'verified'
|          |
|          launch
java.lang.AssertionError: Spring application runner fixture timed out after 30 seconds
	at org.grails.cli.command.run.SpringApplicationRunnerSpec.awaitProcess(SpringApplicationRunnerSpec.groovy:85)
	at org.grails.cli.command.run.SpringApplicationRunnerSpec.runFixture(SpringApplicationRunnerSpec.groovy:63)
	at org.grails.cli.command.run.SpringApplicationRunnerSpec.ROOT OFF prints #failureMode failures to stderr(SpringApplicationRunnerSpec.groovy:34)

	at org.grails.cli.command.run.SpringApplicationRunnerSpec.ROOT OFF prints #failureMode failures to stderr(SpringApplicationRunnerSpec.groovy:34)
Caused by: java.lang.AssertionError: Spring application runner fixture timed out after 30 seconds
	at org.grails.cli.command.run.SpringApplicationRunnerSpec.awaitProcess(SpringApplicationRunnerSpec.groovy:85)
	at org.grails.cli.command.run.SpringApplicationRunnerSpec.runFixture(SpringApplicationRunnerSpec.groovy:63)
	... 1 more

Rerun Controls

Select tests to mute in this pull request:

• SpringApplicationRunnerSpec > ROOT OFF prints #failureMode failures to stderr

Reuse successful test results:

• ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

• Rerun jobs

---

Learn more about TestLens at testlens.app/docs.