Repository navigation
fix(i18n): Update Japanese translations - #45264
aikawa-ohno wants to merge 39 commits into
Conversation
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45264 +/- ##
=======================================
Coverage 65.35% 65.35%
=======================================
Files 3083 3083
Lines 211224 211224
Branches 49803 49803
=======================================
Hits 138054 138054
Misses 69992 69992
Partials 3178 3178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
| @@ -7413,10 +7466,10 @@ msgid "Force date format" | |||
| msgstr "日付形式を強制" | |||
|
|
|||
| msgid "Force disabled" | |||
| msgstr "" | |||
| msgstr "強制を無効" | |||
There was a problem hiding this comment.
強制を無効 / 強制を有効 read as "disable/enable forcing", but these are the force_off / force_on choices for asynchronous query execution in the dashboard properties modal. A user could pick "disable forcing" expecting it to clear the override, when it actually forces async execution off. Would 強制的に無効 / 強制的に有効 (the "forcibly off/on" reading) be closer to the English?
|
|
||
| msgid "Archived" | ||
| msgstr "" | ||
| msgstr "アーカイブ日" |
There was a problem hiding this comment.
Archived is now アーカイブ日 ("archive date"), but this is a context-free msgid that is also used as the status marker label in ArchivedDatasetPurgeModal (aria-label={t('Archived')}). Screen-reader users reviewing purge dependencies would hear "archive date" for a status with no date. Would a neutral アーカイブ済み work for both places?
| @@ -10020,6 +10075,10 @@ msgid "" | |||
| " channel from the dropdown, or copy its id from Slack (channel name, View" | |||
| " channel details, the id is at the bottom)." | |||
| msgstr "" | |||
| "Slack チャンネル ID ではありません: %(invalid)s。Superset は report の添付ファイルを " | |||
There was a problem hiding this comment.
The word report is left in English in the Slack channel-id error (Superset は report の添付ファイルを), so users see mixed-language text when they enter an invalid channel. Should this be レポート?
|
Thank you for your review. 「強制を無効 / 強制を有効」 msgid "Force categorical" 「アーカイブ日」 「report」 |
| @@ -10333,22 +10392,22 @@ msgid "Opacity, expects values between 0 and 100" | |||
| msgstr "不透明度(0から100の間の値)" | |||
|
|
|||
| msgid "Open" | |||
| msgstr "" | |||
| msgstr "開く" | |||
There was a problem hiding this comment.
Open/High/Low (also lines 7822 and 9021) are the Candlestick chart's metric control labels and tooltip rows, but they are now 開く / 高い / 低い ("to open", "is high", "is low"), while this same file's help text for those controls uses 始値 / 高値 / 安値. A Japanese user setting up an OHLC chart would see action/adjective labels on the controls instead of the financial terms. Since the msgids are context-free and also used as generic labels elsewhere, would the financial terms still read acceptably there, or should these stay untranslated until the source strings get a context?
|
Thank you for all your feedback. 「python-format」 Changed to “no-python-format” 「高い / 低い」 Since “始値、高値、安値、終値” are the standard terms used in OHLC charts, I have standardized the terminology. Please let me know the following. I generally do not change flags (other than fuzzy ones). |
|
Since “Close” seems to be used in many other places, I haven't changed it. |
|
I know you're busy, but could you please leave a review? |
|
|
||
| msgid "" | ||
| "Minimum gap between two axis ticks. Only applies to numeric and time " | ||
| "axes, where time is expressed in milliseconds. Leave empty for automatic." | ||
| msgstr "" | ||
| "2つの軸の目盛間の最小間隔。数値軸および時間がミリ秒単位で表示される時間軸にのみ適用されます。" |
There was a problem hiding this comment.
The English says the gap applies to "time axes, where time is expressed in milliseconds", meaning the value you type is in milliseconds. This translation says 「時間がミリ秒単位で表示される時間軸」, i.e. time axes that are displayed in milliseconds. A Japanese user charting calendar dates could read this as "not available for my axis", or enter 1 expecting one day instead of 86400000. Could this say that the interval is specified in milliseconds for time axes?
There was a problem hiding this comment.
I have revised the wording to make it clear and avoid any misunderstandings.
The Japanese translation has been updated.
・I translated what hadn't been translated.
・Minor corrections were made.
Due to a failure in source control, I have closed the previous pull request and will create a new one using the latest files.