Skip to content

fix(i18n): Update Japanese translations - #45264

Open
aikawa-ohno wants to merge 39 commits into
apache:masterfrom
aikawa-ohno:Japanese
Open

aikawa-ohno wants to merge 39 commits into
apache:masterfrom
aikawa-ohno:Japanese

Conversation

@aikawa-ohno

Copy link
Copy Markdown
Contributor

The Japanese translation has been updated.

・I translated what hadn't been translated.
・Minor corrections were made.

Due to a failure in source control, I have closed the previous pull request and will create a new one using the latest files.

  • Changes UI

@github-actions github-actions Bot added i18n Namespace | Anything related to localization i18n:japanese Translation related to Japanese language labels Oct 14, 2026
@codeant-ai-for-open-source

codeant-ai-for-open-source Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: f1471c79cf4b

@netlify

netlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit f1471c7
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6af26772b9d0df3efe826474
😎 Deploy Preview https://deploy-preview-45264--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.35%. Comparing base (a131fcb) to head (f1471c7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #45264   +/-   ##
=======================================
  Coverage   65.35%   65.35%           
=======================================
  Files        3083     3083           
  Lines      211224   211224           
  Branches    49803    49803           
=======================================
  Hits       138054   138054           
  Misses      69992    69992           
  Partials     3178     3178           
Flag Coverage Δ
hive 34.05% <ø> (ø)
mysql 51.81% <ø> (+<0.01%) ⬆️
postgres 51.84% <ø> (ø)
presto 35.69% <ø> (ø)
python 52.13% <ø> (ø)
sqlite 51.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe
sadpandajoe requested review from sadpandajoe and a balanced review from Copilot October 14, 2026 21:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@@ -7413,10 +7466,10 @@ msgid "Force date format"
msgstr "日付形式を強制"

msgid "Force disabled"
msgstr ""
msgstr "強制を無効"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

強制を無効 / 強制を有効 read as "disable/enable forcing", but these are the force_off / force_on choices for asynchronous query execution in the dashboard properties modal. A user could pick "disable forcing" expecting it to clear the override, when it actually forces async execution off. Would 強制的に無効 / 強制的に有効 (the "forcibly off/on" reading) be closer to the English?


msgid "Archived"
msgstr ""
msgstr "アーカイブ日"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archived is now アーカイブ日 ("archive date"), but this is a context-free msgid that is also used as the status marker label in ArchivedDatasetPurgeModal (aria-label={t('Archived')}). Screen-reader users reviewing purge dependencies would hear "archive date" for a status with no date. Would a neutral アーカイブ済み work for both places?

@@ -10020,6 +10075,10 @@ msgid ""
" channel from the dropdown, or copy its id from Slack (channel name, View"
" channel details, the id is at the bottom)."
msgstr ""
"Slack チャンネル ID ではありません: %(invalid)s。Superset は report の添付ファイルを "

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word report is left in English in the Slack channel-id error (Superset は report の添付ファイルを), so users see mixed-language text when they enter an invalid channel. Should this be レポート?

@aikawa-ohno

Copy link
Copy Markdown
Contributor Author

@sadpandajoe

Thank you for your review.

「強制を無効 / 強制を有効」
Considering the points raised and the need for consistency with the following, I believe the proposed translation is appropriate, so I will make the correction.

msgid "Force categorical"
msgstr "強制的にカテゴリ化"

「アーカイブ日」
As far as ArchivedList is concerned, 「アーカイブ日」 would be more appropriate; however, since it is not suitable when considering the status display used in ArchivedDatasetPurgeModal, I will revise it to a more neutral term.

「report」
As pointed out, some words have been left in English, so we will correct them.

@@ -10333,22 +10392,22 @@ msgid "Opacity, expects values between 0 and 100"
msgstr "不透明度(0から100の間の値)"

msgid "Open"
msgstr ""
msgstr "開く"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open/High/Low (also lines 7822 and 9021) are the Candlestick chart's metric control labels and tooltip rows, but they are now 開く / 高い / 低い ("to open", "is high", "is low"), while this same file's help text for those controls uses 始値 / 高値 / 安値. A Japanese user setting up an OHLC chart would see action/adjective labels on the controls instead of the financial terms. Since the msgids are context-free and also used as generic labels elsewhere, would the financial terms still read acceptably there, or should these stay untranslated until the source strings get a context?

@aikawa-ohno

Copy link
Copy Markdown
Contributor Author

@sadpandajoe

Thank you for all your feedback.

「python-format」

Changed to “no-python-format”

「高い / 低い」

Since “始値、高値、安値、終値” are the standard terms used in OHLC charts, I have standardized the terminology.

Please let me know the following.

I generally do not change flags (other than fuzzy ones).
It appears that the flag is set to “python-format” in messages.po—would it be okay to just modify the POT file when translating?

@aikawa-ohno

Copy link
Copy Markdown
Contributor Author

Since “Close” seems to be used in many other places, I haven't changed it.

@github-actions github-actions Bot added the requires:rebase Requires rebasing on top of current master label Oct 20, 2026
@github-actions github-actions Bot removed the requires:rebase Requires rebasing on top of current master label Oct 21, 2026
@github-actions github-actions Bot added the requires:rebase Requires rebasing on top of current master label Oct 28, 2026
@github-actions github-actions Bot removed the requires:rebase Requires rebasing on top of current master label Oct 28, 2026
@aikawa-ohno

Copy link
Copy Markdown
Contributor Author

@sadpandajoe

I know you're busy, but could you please leave a review?

@github-actions github-actions Bot added the requires:rebase Requires rebasing on top of current master label Oct 31, 2026
@github-actions github-actions Bot removed the requires:rebase Requires rebasing on top of current master label Nov 3, 2026

@aikawa-ohno aikawa-ohno left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadpandajoe

The corrections have been completed.


msgid ""
"Minimum gap between two axis ticks. Only applies to numeric and time "
"axes, where time is expressed in milliseconds. Leave empty for automatic."
msgstr ""
"2つの軸の目盛間の最小間隔。数値軸および時間がミリ秒単位で表示される時間軸にのみ適用されます。"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English says the gap applies to "time axes, where time is expressed in milliseconds", meaning the value you type is in milliseconds. This translation says 「時間がミリ秒単位で表示される時間軸」, i.e. time axes that are displayed in milliseconds. A Japanese user charting calendar dates could read this as "not available for my axis", or enter 1 expecting one day instead of 86400000. Could this say that the interval is specified in milliseconds for time axes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have revised the wording to make it clear and avoid any misunderstandings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n:japanese Translation related to Japanese language i18n Namespace | Anything related to localization size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants