Repository navigation
Conversation
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45933 +/- ##
=======================================
Coverage 65.35% 65.35%
=======================================
Files 3083 3083
Lines 211333 211335 +2
Branches 49823 49820 -3
=======================================
+ Hits 138110 138112 +2
Misses 70041 70041
Partials 3182 3182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rebenitez1802
approved these changes
Nov 2, 2026
rebenitez1802
left a comment
rebenitez1802
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Verified the new test fails without the fix (assert 1 == 0) and passes with it, and that unrelated connect_args from encrypted_extra (e.g. ssl) are preserved. Since encrypted_extra is only writable with can_write on Database (Admin), this is hardening rather than a vulnerability fix. A few optional nits inline, none blocking.
…xtra The engine spec's enforced connection arguments (enforce_uri_query_params) are applied in adjust_engine_params, while encrypted_extra is merged into the engine kwargs later in Database._get_sqla_engine. Re-apply the enforced arguments after that merge so the engine spec stays the single source of truth for them. Other connect_args, including those from encrypted_extra, are preserved. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
sha174n
force-pushed
the
fix-enforced-connect-args-ordering
branch
from
November 10, 2026 15:55
53b1b26 to
f8b96f2
Compare
Rebuild connect_args into a fresh dict so a non-dict value supplied via encrypted_extra (null, a list of pairs) is coerced instead of raising a raw AttributeError, and clarify that specs overriding adjust_engine_params without super() still get the enforced arguments applied last. Add coverage for the non-dict case and for per-key merge preserving an unrelated entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ect-args-ordering
…ect-args-ordering
The bare Mock user's is_guest_user attribute is truthy, so the RLS tool tests fail whenever EMBEDDED_SUPERSET is left enabled by an earlier test in the same worker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The engine spec's enforced connection arguments (
enforce_uri_query_params, e.g. for MySQL drivers) are applied inadjust_engine_params, whileencrypted_extrais merged into the engine kwargs later inDatabase._get_sqla_engine. This re-applies the enforced arguments after that merge so the engine spec stays the single source of truth for them. Only engine specs that declareenforce_uri_query_paramsare affected; all otherconnect_args, including those fromencrypted_extra, are preserved.TESTING INSTRUCTIONS
pytest tests/unit_tests/models/core_test.py -k enforced_connect_args_outlast_encrypted_extraADDITIONAL INFORMATION