Repository navigation
fix(packaging): declare CLI dependency and document matched-core source installs - #45938
alberttwong wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #45938 +/- ##
===========================================
- Coverage 84.96% 65.20% -19.77%
===========================================
Files 3078 3079 +1
Lines 208652 210052 +1400
Branches 49167 49367 +200
===========================================
- Hits 177288 136969 -40319
- Misses 27992 69928 +41936
+ Partials 3372 3155 -217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Fixed the Netlify build failure in commit 9520dce: the source-installation link now uses /developer-docs/contributing/development-setup#flask-server to cross the admin/developer Docusaurus sections. Verified the target page and Flask-server anchor, and verified the committed diff changes exactly that link. The replacement Netlify deploy preview is successful: https://deploy-preview-45938--superset-docs-preview.netlify.app . No new local pre-commit or full docs build was run; validation here is the exact change and hosted preview build. |
SUMMARY
A fresh source install can select an older published
apache-superset-corewith incompatible SQLAlchemy requirements, and the CLI importsricheven though package metadata does not declare it. Declarerichdirectly and document installing the application and core together from the same checkout, including the editable development command.Refs #45937 and #42568. This addresses the Superset packaging portion of #45937; it does not close the broader Flight SQL compatibility report. Table/type reflection fixes belong to the third-party adapter and are being submitted separately. The
richdeclaration also overlaps the broader, still-open Python 3.15 work in #45823; this PR offers the small independently validated packaging fix.No core version bound is invented before a matching package is published. The source-install command uses the matching local core without bypassing dependency resolution.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; dependency metadata and documentation only.
TESTING INSTRUCTIONS
Validated on Python 3.12.16, macOS arm64, against master
7519fa8b6f5a145097d51e36579240e872044266:python -m pip install /path/to/superset /path/to/superset/superset-core(plus pytest, pre-commit and build as validation tools).rich==15.0.0was installed through application metadata, without an explicit rich install.python -m pip check: no broken requirements.superset --helpsucceeds with disposable local configuration.superset db upgradeagainst a fresh isolated SQLite metadata database succeeds./health: HTTP 200.pre-commit runon all three staged files: all applicable checks passed.git diff --check: passed.Reproduce with a clean Python 3.12 environment, the documented source-install command, and a disposable Superset configuration. No existing metadata or running deployment needs changing.
Separately, the adapter fix was exercised with Superset 7.0.0rc2 against a disposable Redis Arrow Flight SQL endpoint: table discovery, BIGINT/VARCHAR/FLOAT column reflection, ordered/NULL/empty reads, SQL Lab CREATE/INSERT/UPDATE/DELETE/DROP with read-back assertions, dataset creation, and a grouped chart data query passed. Browser rendering and production behavior remain unverified.
ADDITIONAL INFORMATION