Skip to content

fix(packaging): declare CLI dependency and document matched-core source installs - #45938

Open
alberttwong wants to merge 3 commits into
apache:masterfrom
alberttwong:codex/fix-source-install-45937
Open

alberttwong wants to merge 3 commits into
apache:masterfrom
alberttwong:codex/fix-source-install-45937

Conversation

@alberttwong

Copy link
Copy Markdown

SUMMARY

A fresh source install can select an older published apache-superset-core with incompatible SQLAlchemy requirements, and the CLI imports rich even though package metadata does not declare it. Declare rich directly and document installing the application and core together from the same checkout, including the editable development command.

Refs #45937 and #42568. This addresses the Superset packaging portion of #45937; it does not close the broader Flight SQL compatibility report. Table/type reflection fixes belong to the third-party adapter and are being submitted separately. The rich declaration also overlaps the broader, still-open Python 3.15 work in #45823; this PR offers the small independently validated packaging fix.

No core version bound is invented before a matching package is published. The source-install command uses the matching local core without bypassing dependency resolution.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; dependency metadata and documentation only.

TESTING INSTRUCTIONS

Validated on Python 3.12.16, macOS arm64, against master 7519fa8b6f5a145097d51e36579240e872044266:

  • Fresh virtual environment: python -m pip install /path/to/superset /path/to/superset/superset-core (plus pytest, pre-commit and build as validation tools). rich==15.0.0 was installed through application metadata, without an explicit rich install.
  • python -m pip check: no broken requirements.
  • Installed package metadata declares rich; superset --help succeeds with disposable local configuration.
  • superset db upgrade against a fresh isolated SQLite metadata database succeeds.
  • Application creation and /health: HTTP 200.
  • pre-commit run on all three staged files: all applicable checks passed.
  • git diff --check: passed.

Reproduce with a clean Python 3.12 environment, the documented source-install command, and a disposable Superset configuration. No existing metadata or running deployment needs changing.

Separately, the adapter fix was exercised with Superset 7.0.0rc2 against a disposable Redis Arrow Flight SQL endpoint: table discovery, BIGINT/VARCHAR/FLOAT column reflection, ordered/NULL/empty reads, SQL Lab CREATE/INSERT/UPDATE/DELETE/DROP with read-back assertions, dataset creation, and a grouped chart data query passed. Browser rendering and production behavior remain unverified.

ADDITIONAL INFORMATION

@github-actions github-actions Bot added the doc Namespace | Anything related to documentation label Nov 2, 2026
@codeant-ai-for-open-source

codeant-ai-for-open-source Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 9520dcec62b2

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.20%. Comparing base (2a8be96) to head (9520dce).
⚠️ Report is 60 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (2a8be96) and HEAD (9520dce). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (2a8be96) HEAD (9520dce)
python 7 4
postgres 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #45938       +/-   ##
===========================================
- Coverage   84.96%   65.20%   -19.77%     
===========================================
  Files        3078     3079        +1     
  Lines      208652   210052     +1400     
  Branches    49167    49367      +200     
===========================================
- Hits       177288   136969    -40319     
- Misses      27992    69928    +41936     
+ Partials     3372     3155      -217     
Flag Coverage Δ
hive ?
mysql 51.88% <ø> (-0.22%) ⬇️
postgres 51.90% <ø> (-0.22%) ⬇️
presto 35.77% <ø> (-0.11%) ⬇️
python 52.13% <ø> (-35.79%) ⬇️
sqlite 51.64% <ø> (-0.22%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify

netlify Bot commented Nov 9, 2026

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 9520dce
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6af2098ccafd59a9a82f101c
😎 Deploy Preview https://deploy-preview-45938--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@alberttwong

Copy link
Copy Markdown
Author

Fixed the Netlify build failure in commit 9520dce: the source-installation link now uses /developer-docs/contributing/development-setup#flask-server to cross the admin/developer Docusaurus sections. Verified the target page and Flask-server anchor, and verified the committed diff changes exactly that link. The replacement Netlify deploy preview is successful: https://deploy-preview-45938--superset-docs-preview.netlify.app . No new local pre-commit or full docs build was run; validation here is the exact change and hosted preview build.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Namespace | Anything related to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant