Repository navigation
fix(semantic-layer): keep the guest RLS refusal reason in chart-data responses - #46126
Draft
mikebridge wants to merge 1 commit into
Draft
mikebridge wants to merge 1 commit into
mikebridge wants to merge 1 commit into
Conversation
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #46126 +/- ##
==========================================
- Coverage 65.42% 65.36% -0.06%
==========================================
Files 3082 3083 +1
Lines 210951 211231 +280
Branches 49720 49805 +85
==========================================
+ Hits 138006 138066 +60
- Misses 69768 69987 +219
- Partials 3177 3178 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Chart-data requests from embedded guests with row-level rules that a semantic view cannot enforce still receive a 403. The response now explains that limitation so the host can choose a supported data source or adjust its guest rules.
Background: Semantic views already refuse applicable guest row-level security rules.
Problem: The chart-data API replaced that refusal's fixed explanation with a generic 403.
What this changes:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; this changes an API error message.
TESTING INSTRUCTIONS
With
SEMANTIC_LAYERSandEMBEDDED_SUPERSETenabled, request chart data for a semantic view as an embedded guest with an applicable guest row-level rule. Both saved-chart GET and submitted POST should return 403 withSemantic views cannot enforce guest row-level security rules.and no result. With no applicable rule, the request should retain its normal response. Other security denials should remain generic. Automated checks:pytest -q tests/integration_tests/semantic_layers/guest_rls_message_test.py tests/unit_tests/security/guest_rls_test.pyand the MCP chart-data categorization cases.ADDITIONAL INFORMATION
SEMANTIC_LAYERS,EMBEDDED_SUPERSET