Repository navigation
ci: publish to PyPI from a single workflow - #1201
Merged
Merged
Conversation
vdusek
added
the
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
+ Coverage 95.71% 95.73% +0.01%
==========================================
Files 62 62
Lines 6656 6656
==========================================
+ Hits 6371 6372 +1
+ Misses 285 284 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
November 5, 2026 10:25
apify-factory
left a comment
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 14/16 — file-extensions, deny-globs |
| Review findings | ✅ none |
| Reviewer escalation | ❌ The change moves PyPI Trusted Publishing to a new workflow, and someone has to register a matching publisher on PyPI before merging or the next release fails to publish. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: .github/workflows/manual_release_beta.yaml, .github/workflows/manual_release_stable.yaml, .github/workflows/on_master.yaml, .github/workflows/publish_to_pypi.yamldeny-globs: .github/workflows/manual_release_beta.yaml matches .github/; .github/workflows/manual_release_stable.yaml matches .github/; .github/workflows/on_master.yaml matches .github/; .github/workflows/publish_to_pypi.yaml matches .github/
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 76a9cc29f · workflow run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta and stable releases are published to PyPI from different workflows (
manual_release_beta.yamlandmanual_release_stable.yaml), so PyPI shows a "Change of provenance" warning on every stable release that follows a beta. All publishing now happens in a newpublish_to_pypi.yaml, which both release workflows dispatch withapify/actions/execute-workflow. Crawlee JS runspublish-to-npm.ymlthe same way.Before merging, add a PyPI trusted publisher for
apify-clientwith workflowpublish_to_pypi.yamland environmentpypi. Remove the old ones once the first release goes through.Relates to: apify/crawlee-python#2382
✍️ Drafted by Claude Code