Skip to content

feat: add server_* arguments and deprecate actor_standby_* ones - #1202

Merged
vdusek merged 3 commits into
masterfrom
feat/rename-standby-args
Nov 5, 2026
Merged

vdusek merged 3 commits into
masterfrom
feat/rename-standby-args

Conversation

@vdusek

@vdusek vdusek commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Renames the actor_standby_* arguments of ActorClient.update, ActorCollectionClient.create, TaskClient.update, and TaskCollectionClient.create (sync and async) to the Server Actor naming used by ActorClient.server():

Deprecated New
actor_standby_is_enabled server_is_enabled
actor_standby_desired_requests_per_actor_run server_desired_requests_per_actor_run
actor_standby_max_requests_per_actor_run server_max_requests_per_actor_run
actor_standby_idle_timeout server_idle_timeout
actor_standby_build server_build
actor_standby_memory_mbytes server_memory_mbytes
actor_standby_disable_standby_fields_override server_disable_fields_override
actor_standby_should_pass_actor_input server_should_pass_actor_input

The task methods take the five arguments they had before. The old names stay as deprecated aliases until v4, the same way as build_tag in validate_input(). Each one set emits a DeprecationWarning at the caller, and passing an alias together with its new name raises a ValueError. All eight methods share one helper, build_actor_standby, which maps the aliases and builds the actorStandby field.

actor_standby_tenancy from #1169 isn't on master yet, so it isn't covered here. #1169 can add it as server_tenancy directly, without an alias. It should ship in the same release as #1153.

Closes: #1195

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 5, 2026
@vdusek vdusek self-assigned this Nov 5, 2026
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.74%. Comparing base (f355d89) to head (93342d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
+ Coverage   95.71%   95.74%   +0.02%     
==========================================
  Files          62       63       +1     
  Lines        6656     6678      +22     
==========================================
+ Hits         6371     6394      +23     
+ Misses        285      284       -1     
Flag Coverage Δ
integration 91.03% <77.27%> (-0.08%) ⬇️
unit 90.70% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested review from Pijukatel and janbuchar November 5, 2026 10:33
@vdusek
vdusek marked this pull request as ready for review November 5, 2026 10:33
@vdusek
vdusek requested a review from szaganek as a code owner November 5, 2026 10:33
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Nov 5, 2026
@vdusek vdusek changed the title feat: rename actor_standby_* arguments to server_* feat: add server_* arguments and deprecate actor_standby_* ones Nov 5, 2026
@vdusek
vdusek merged commit e8ef135 into master Nov 5, 2026
46 checks passed
@vdusek
vdusek deleted the feat/rename-standby-args branch November 5, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename actor_standby_* arguments to Server Actor naming

3 participants