Repository navigation
fix: correct helm upgrade command in Kubernetes update guide - #3110
Open
wyattwalter wants to merge 2 commits into
Open
wyattwalter wants to merge 2 commits into
wyattwalter wants to merge 2 commits into
Conversation
The update guide ran `helm upgrade` with only the release name. Helm requires both the release and the chart, so the command failed with: "helm upgrade" requires 2 arguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the values.yaml and yq steps with one helm upgrade command. The command keeps the release's values, applies the new chart defaults, and sets the image tag. Add a fallback that keeps the installed chart version when the new chart schema rejects existing values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The Kubernetes steps in "Update Appsmith" run
helm upgradewith only the release name. Helm fails with"helm upgrade" requires 2 arguments. The steps also make the user find or rebuildvalues.yamland edit it withyq.The fix: Use one
helm upgradecommand with the chart name,--reset-then-reuse-valuesand--set image.tag=<version>. Add a step for when the chart schema rejects existing values.Tradeoff: The upgrade moves the chart to its latest version. If a release value is not compatible with the new chart, Helm rejects the upgrade before it changes anything. The new fallback step keeps the installed chart version and updates only the image.
Description
Kubernetes tab of
getting-started/setup/instance-management/update-appsmith.mdx:helm repo update appsmith-ee.helm upgrade appsmith-ee appsmith-ee/appsmith -n appsmith-ee --reset-then-reuse-values --set image.tag=<version>. Users who keepvalues.yamlin source control setimage.tagthere and pass-f values.yaml.values don't meet the specifications of the schema(s), either fix the listed values, or pin the installed chart version:helm upgrade ... --version "$CHART_VERSION" --reuse-values --set image.tag=<version>.CHART_VERSIONcomes fromhelm get metadata.--reset-then-reuse-valuesapplies the new chart defaults, then the values of the current release, then the command-line overrides.--reuse-valueswould replace the new chart defaults with the old chart defaults. Both--reset-then-reuse-valuesandhelm get metadataexist in Helm 3.14, the minimum version in the Kubernetes installation guide.Pull request type
Verification
Error: "helm upgrade" requires 2 arguments.helm show chart --repo https://helm-ee.appsmith.com appsmithreturnsname: appsmith,version: 3.9.3.helm templatewith--set image.pullPolicy=Sometimesreturnsvalues don't meet the specifications of the schema(s).TabItem. Validate the page on the deploy preview.Rollback
Revert this PR.
🤖 Generated with Claude Code