Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description:
asdf-community/asdf-jetbrainsinstalls JetBrains IDEs and the Toolbox App; likeasdf-community/asdf-hashicorp, the plugin name defines the product. The registry has only the short namejetbrains, which names no product, soasdf plugin add jetbrainsgives a plugin that cannot list or install anything. This PR adds one short name per product. The short name is the command the plugin puts on PATH, as withterraformorvaultfor asdf-hashicorp:clion,datagrip,dataspell,gateway,goland,idea,ideac,mps,phpstorm,pycharm,pycharmc,rider,rubymine,rustrover,webstorm, andjetbrains-toolboxfor the Toolbox App (its command isjetbrains-toolbox, and it avoids taking the generic nametoolbox).ideacandpycharmcare the Community Editions, which have no releases after 2025.3 but are still installable.The existing
jetbrainsentry stays: removing it would fail the registry check for deleted plugin files, and since asdf-jetbrains 1.3.1 the plugin explains there how to add a product.Checklist
scripts/format.bashscripts/test_plugin.bash --file plugins/<your_new_plugin_name>(all 16, and--diff origin/master HEADas in CI)plugin-testbecauseasdf plugin testcurrently ignores the test command, see fix: run the test command of plugin test asdf#2351.