Repository navigation
docs(agents): require a review on every pr before merge - #414
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for flashlight-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413
Description
Every PR is now reviewed before it merges, by someone other than its author: a person, or a review agent. An agent never reviews or approves a PR it wrote, and a human merges.
.claude/rules/engineering-standards.md(Git and PRs): the rule, plus a note thatmainrequires one approval. "Never merge your own PR as an agent" becomes "never merge a PR as an agent"..claude/rules/agent-workflow.md: the skill map goes on past/prto the review and a human merge. A new ground rule says an agent's own/code-reviewon its diff doesn't count as the PR review..github/pull_request_template.md: adds a**Reviewer:**line.AGENTS.mdonly links to the rule files and has no list of PR rules, so it is unchanged.GitHub enforcement is already on:
mainrequires 1 approval, and force-push is disabled with no bypass. Because GitHub only counts approvals from a user with write access who isn't the author, a review agent's COMMENT review doesn't satisfy the check. In practice a person approves.The factory run for this issue was blocked from editing
.claude/rules/, so this change was applied by hand.Type of change
Validation
Docs only.
prettier --check .claude/rules .github/pull_request_template.mdpasses. The rule files must stay identical inbamlab/flashlight-cloud; the same text goes into that repo's PR.Merge danger
Door: two-way.
Blast radius: agents and contributors following the rules; no code changes.
🤖 Generated with Claude Code