Skip to content

docs(agents): require a review on every pr before merge - #414

Merged
AlecColas merged 1 commit into
mainfrom
docs/require-pr-review
Nov 17, 2026
Merged

AlecColas merged 1 commit into
mainfrom
docs/require-pr-review

Conversation

@AlecColas

Copy link
Copy Markdown
Contributor

Closes #413

Description

Every PR is now reviewed before it merges, by someone other than its author: a person, or a review agent. An agent never reviews or approves a PR it wrote, and a human merges.

  • .claude/rules/engineering-standards.md (Git and PRs): the rule, plus a note that main requires one approval. "Never merge your own PR as an agent" becomes "never merge a PR as an agent".
  • .claude/rules/agent-workflow.md: the skill map goes on past /pr to the review and a human merge. A new ground rule says an agent's own /code-review on its diff doesn't count as the PR review.
  • .github/pull_request_template.md: adds a **Reviewer:** line.

AGENTS.md only links to the rule files and has no list of PR rules, so it is unchanged.

GitHub enforcement is already on: main requires 1 approval, and force-push is disabled with no bypass. Because GitHub only counts approvals from a user with write access who isn't the author, a review agent's COMMENT review doesn't satisfy the check. In practice a person approves.

The factory run for this issue was blocked from editing .claude/rules/, so this change was applied by hand.

Type of change

  • Docs

Validation

Docs only. prettier --check .claude/rules .github/pull_request_template.md passes. The rule files must stay identical in bamlab/flashlight-cloud; the same text goes into that repo's PR.

Merge danger

Door: two-way.

Blast radius: agents and contributors following the rules; no code changes.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for flashlight-docs canceled.

Name Link
🔨 Latest commit cb04f5b
🔍 Latest deploy log https://app.netlify.com/projects/flashlight-docs/deploys/6afb07ce0420323a425b4ccc

@AlecColas
AlecColas marked this pull request as ready for review November 17, 2026 08:52
@AlecColas AlecColas self-assigned this Nov 17, 2026
@AlecColas
AlecColas merged commit 5eeee8a into main Nov 17, 2026
6 checks passed
@AlecColas
AlecColas deleted the docs/require-pr-review branch November 17, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(agents): require a review on every PR before merge

1 participant