[iFixRobots]

Slack lets people name group DMs now. A named one comes back from conversations.info and client.userBoot with the custom name in name and properties.has_custom_mpdm_name: true. Unnamed ones still have the mpdm-… name and no flag. This exposes the flag so mautrix-slack can tell the two apart.

Tag @indent to continue the conversation here.

[indent]

Issues

No issues found.

CI Checks

CI fails on the base fork, not because of this one-field change. Test files no longer compile against the fork's API, and the Go 1.26 test run also hits a slackevents panic and slacktest RTM timeouts.

lint go-1.25

• golangci-lint's typecheck fails on test files that don't match the fork's API: conversation_test.go:804 uses GetConversationRepliesParameters.ChannelID and api.GetConversationReplies, which don't exist, and files_test.go:170,376,404,437 use []FileSummary where []File is expected. The PR only adds HasCustomMpdmName to Properties, which can't cause these. They come from the beeper branch diverging from upstream tests.

test go-1.26

• The root package build fails because of the same test-file compile errors. slackevents also hits a nil-pointer panic in TestUserProfileChanged, and the slacktest RTM tests time out (TestRTMInfo, TestRTMPing, TestRTMDirectMessage, TestRTMChannelMessage). None of these touch conversation.go Properties, so they are not caused by this PR.

lint go-1.26

• Cancelled, with no result of its own. The sibling go-1.25 lint job failed first.

test go-1.25

• Cancelled, with no result of its own. The sibling go-1.26 test job failed first.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)

• Indent Review Agent · No issues found in the one-field addition.

Full results

Indent Review Agent

• Summary: No issues found in the one-field addition.
• Last ran on commit: 167198d6
• Latest result

  {
    "summary": "No issues found in the one-field addition.",
    "findings": []
  }