Skip to content

[PM-46111] ci: Add Flags removed section to release notes - #7551

Open
trmartin4 wants to merge 1 commit into
mainfrom
release-notes-flags-removed
Open

trmartin4 wants to merge 1 commit into
mainfrom
release-notes-flags-removed

Conversation

@trmartin4

@trmartin4 trmartin4 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

🎟️ Tracking

PM-46111

📔 Objective

Add a "🚩 Flags removed" category to the generated release notes for PRs labeled t:flagged-code-removal. Without it, those PRs fall through to "🎨 Other".

The category sits below Maintenance and above Dependency Updates. Cleanup PRs carry only this t: label, so no earlier category claims them.

This will allow feature flag removals (which unlock features for self-hosted customers) to be categorized independently in release notes. Note that this is indicating the removal of flagged code and not the feature flag itself, which must remain in place for backward compatibility.

@trmartin4 trmartin4 added the t:ci Change Type - Updates to automated workflows label Oct 31, 2026
@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.82%. Comparing base (262dba3) to head (d63b7b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7551   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files         896      896           
  Lines       65792    65792           
  Branches     9407     9407           
=======================================
  Hits        57121    57121           
  Misses       5187     5187           
  Partials     3484     3484           
Flag Coverage Δ
app-data 18.69% <ø> (ø)
app-ui-auth-tools 18.62% <ø> (ø)
app-ui-platform 16.47% <ø> (ø)
app-ui-vault 26.97% <ø> (ø)
authenticator 6.02% <ø> (ø)
lib-core-network-bridge 4.12% <ø> (ø)
lib-data-ui 1.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 changed the title ci: Add Flags removed section to release notes [PM-46111] ci: Add Flags removed section to release notes Oct 31, 2026
@trmartin4
trmartin4 marked this pull request as ready for review October 31, 2026 15:28
@trmartin4
trmartin4 requested a review from a team as a code owner October 31, 2026 15:28
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a 🚩 Flags removed category to .github/release.yml for PRs labeled t:flagged-code-removal. It sits between Maintenance and Dependency Updates. GitHub assigns each PR to the first category that matches, and sdlc-enforce-labels.yml requires exactly one t:* label per PR, so these PRs will land in the new category instead of falling through to 🎨 Other. The YAML structure matches the categories around it, and no in-repo documentation describes the release-note categories.

@vvolkgang vvolkgang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in the iOS repo: bitwarden/ios#3177 (review)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants