Repository navigation
fix(calendar-agenda): respect user regional date and time formatting preferences - #29
Merged
Merged
Conversation
…preferences - Use api.i18n.formatTime and api.i18n.formatDate so the agenda respects the user's 12h/24h time format, date locale, and time zone. - Resolve untitled event fallback dynamically in render (titleOf) so language switches update untitled event titles immediately. - Bump calendar-agenda to 1.4.4 and minAppVersion to 1.18.0. - Update test-utils/fake-api.mjs with regional properties and formatIntl helper. - Add test coverage for 12h vs 24h clock, dateLocale, and dynamic translation.
Member
|
Merged with a fix on top (a1608ea). The agenda groups days by the browser's midnight, but the labels used the zone from the settings. When the two differ, a day heading or an all-day event showed the day before. Labels now use the browser's zone too. I also put minAppVersion back to 1.15.0, since the code falls back on older hosts, and synced the lockfile version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
calendar-agendaplugin previously formatted times and dates with the browser's nativetoLocaleTimeString/toLocaleDateString, ignoring the user's regional configuration in webmail (timeFormat12h/24h,dateLocaleoverride, and effectivetimeZone). Additionally, untitled event titles were baked in on fetch, causing them not to re-translate when the user switched language.Changes:
api.i18n.formatTimeandapi.i18n.formatDate(with backwards-compatible fallbacks) so the agenda honors user formatting preferences.titleOf) so language changes update untitled events immediately.BannerAgendachip labels withtitleOfto support dynamic untitled strings and strikethroughs for cancelled events.calendar-agendato version1.4.4withminAppVersion: 1.18.0.calendar-agenda.zip.test-utils/fake-api.mjswith regional formatting capabilities.dateLocale, and dynamic translation.Related