Skip to content

Enable the component model implements feature by default - #14970

Open
jrandolf wants to merge 1 commit into
bytecodealliance:mainfrom
jrandolf:implements-default
Open

jrandolf wants to merge 1 commit into
bytecodealliance:mainfrom
jrandolf:implements-default

Conversation

@jrandolf

@jrandolf jrandolf commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

As discussed in #14914.

LLM summary of the changes
  • Config enables CM_IMPLEMENTS whenever the component-model crate feature is on, like the component model itself, and Config::wasm_component_model_implements documents that default instead of calling the feature a work in progress.
  • docs/stability-wasm-proposals.md moves implements to the on-by-default table with a footnote on its Fuzzed ❌.
  • implements_enabled_by_default checks that a default Engine accepts an implements import. The .wast harness still turns the feature off unless a test asks for it, so implements-disabled.wast still checks the error.

@jrandolf
jrandolf requested review from a team as code owners October 23, 2026 21:00
@jrandolf
jrandolf requested review from alexcrichton and dicej and removed request for a team October 23, 2026 21:00
@github-actions github-actions Bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime wasmtime:docs Issues related to Wasmtime's documentation labels Oct 23, 2026
@github-actions

Copy link
Copy Markdown

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

WASI 0.3.1 adopted `implements` and `external-id` annotations on
plain-named interface imports and exports, and runtimes must support
them to be compatible with WASI 0.3.1 and later.

The proposal isn't fuzzed. The attributes are metadata that don't affect
type checking, compilation or execution, so the stability docs note that
they're covered by tests instead.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime wasmtime:docs Issues related to Wasmtime's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant