Repository navigation
Read a word PostgreSQL has no interval qualifier for as an alias - #205
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apache/datafusion-sqlparser-rs#2775 made sqlparser parse
interval '1' weekthe way PostgreSQL does: the interval has no unit andweekis a column alias. pg2sqlite then reads the bare'1'as one second, which is what PostgreSQL 18 answers, sotimestamp '2026-01-31' + interval '1' weekgives2026-01-31 00:00:01. The test that expected pg2sqlite to refuse that spelling now fails on main.This replaces it with tests for what PostgreSQL answers for
week,daysanddecade, and checks that a range PostgreSQL's grammar lacks,YEAR TO DAY, is still refused. No source change is needed.CI needs connetto-rs/sql-traits#197 first, because sqlparser's new
GrantObjectsroutine variants currently break sql-traits main.