Repository navigation
Fix: Add proper error handling to CompositeConnectionDetails - #663
Open
ogormans-deptstack wants to merge 1 commit into
Open
ogormans-deptstack wants to merge 1 commit into
ogormans-deptstack wants to merge 1 commit into
Conversation
Signed-off-by: Sean O'Gorman <sean.ogorman@deptagency.com>
ogormans-deptstack
requested review from
adamwg,
bobh66,
ezgidemirel,
phisco,
sergenyalcin,
turkenf and
ulucinar
as code owners
November 3, 2026 12:09
Author
|
@sergenyalcin |
ezgidemirel
approved these changes
Nov 11, 2026
ezgidemirel
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the PR @ogormans-deptstack, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds proper error handling to the
CompositeConnectionDetailsmeta kind handler. Previously, base64 decode errors and missing 'data' fields were silently suppressed, leading to cryptic downstream Crossplane errors. Now:response.Fatal()with actionable messages (matching Context/ExtraResources pattern)Fixes #40
Testing
Added table-driven test cases for:
All cases verify response.Fatal() is called and error message is set correctly.
Checklist