[botandbang]

What and why

The sidecar gains three methods. store.serve serves the store to another computer until it's cancelled. It sends a serve notification {id, event} for each thing that happens (ready with the share code, connected, refused, done) and answers with how much it sent. store.fetch {code, libraries?, local_only?, dry_run?} copies the snapshots the other store has and this one lacks. Both work like store serve and store fetch. They're in builds with peers, and initialize lists a peers capability. snapshot.library {snapshot, offset?, limit?} reads the library a drive had when a snapshot was taken, paged like drive.library. Plugins with store:read may call it. To support the notification, a method's Call can now send one about its own request. docs/rpc is regenerated and only adds definitions. docs/sidecar.md describes the new methods.

The progress event has one definition, in loclib-plugin's protocol. The sidecar re-exports it, and ProgressEvent::new builds it from a coalesced report in both the sidecar and the plugin SDK. The wire bytes and schema.json are unchanged, and a new test pins the bytes.

opener::web_address parses the address now. It goes through net::public, which returns the parsed URL, and refuses a user name or password. The browser gets the parsed form. Addresses with credentials or on this computer or its network are refused.

There is now one path resolver, loclib_model::paths::resolved, with without_verbatim_prefix beside it. locallibrary's fsutil and device re-export them. The interop plugin drops its copy and its dunce dependency, so it strips Windows' \\?\ prefix the way the host does for drive roots.

loclib-plugin's README now lists the error kinds the host really shows as its own. apps/locallibrary/TODO.md loses two finished items.

Fixes LOC-42
Fixes #142
Fixes LOC-29
Fixes #129
Fixes LOC-31
Fixes #131
Fixes LOC-30
Fixes #130
Fixes LOC-16
Fixes #113
Fixes LOC-19
Fixes #116

How it was tested

• cargo fmt --check, and cargo clippy --all-targets -- -D warnings for locallibrary, locallibrary-cli, loclib-plugin, locallibrary-plugin-interop and loclib-model.
• Filtered nextest over the touched areas: 388 of 390 pass. The 2 failures are hegel findings in code this branch doesn't touch (interop write.rs and loclib-plugin's manifest test); bnb/property-fixes fixes both test models.
• rpc::the_contract_in_docs_is_current passed after the progress change with no bless (the schema didn't change), then was blessed for the new methods and passes.
• a_store_is_served_and_fetched_through_the_sidecar passed 10 of 10 stress runs, twice.
• Break checks, each failing its new test: ProgressEvent field order swapped, the user and password check removed, snapshot_library ignoring offset, the notification renamed, resolved not following links, and the cancel_method call removed.
• Not run: the full suite and Windows clippy (without_verbatim_prefix has a #[cfg(windows)] body).

Checklist

• Tests cover the change
• For locallibrary: apps/locallibrary/CHANGELOG.md has a line under Unreleased, if people using it will notice
• The READMEs, docs/ and --help still say what the code does (apps/locallibrary/docs/rpc/ too, for a sidecar change)

[linear-code]

LOC-19

LOC-29

LOC-16

LOC-30

LOC-31

LOC-42

[github-actions]

Size

Compared with main. KiB are 1,024 bytes.

	This pull request	main	Change
Client JavaScript	684.7 KiB	684.7 KiB	0 B (0%)
Client JavaScript, brotli	227.6 KiB	227.6 KiB	0 B (0%)
Client CSS	89.6 KiB	89.6 KiB	0 B (0%)
Client CSS, brotli	12.9 KiB	12.9 KiB	0 B (0%)

[github-actions]

Rust coverage

From run 62. Both are held to the thresholds in .cargo/config.toml.

Tests	Lines	Functions	Regions
All	97.4% (84667/86929)	96.52% (13570/14059)	95.67% (186420/194849)
Hegel property tests alone	95.35% (82890/86929)	94.04% (13221/14059)	93.43% (182052/194849)