Repository navigation
fix(web): size loading placeholders from counts the directory already knows - #360
Merged
Merged
Conversation
… knows The press-kit lists and upcoming shows stream in after the page loads, and their placeholders were a single bar or row, so everything below moved when the real list arrived (CLS 0.2 on the public press-kits page on a phone). getProject takes a new `counts` param and answers how many press kits and upcoming shows the project has in the same query, and each list shows that many placeholders shaped like its real cards or rows. The artist search can't know its count before it answers, so its results area keeps the placeholder's height instead. The getProject lexicon changed: run `pnpm lexicons:publish` before deploying.
bnb
previously approved these changes
Nov 1, 2026
# Conflicts: # apps/web/README.md # apps/web/src/routes/dashboard/projects/[slug]/press-kits/+page.svelte
botandbang
enabled auto-merge
November 1, 2026 20:07
bnb
approved these changes
Nov 1, 2026
Coverage Report for apps/web
File Coverage
SizeCompared with main. KiB are 1,024 bytes.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The press-kit lists and upcoming shows stream in after the page loads, and their placeholders were a single bar or row, so everything below moved when the real list arrived. Lighthouse measured CLS 0.199 on the public press-kits page on a phone (budget 0.02), and 0.05 to 0.07 on the dashboard project pages.
getProjecttakes a newcountsparam and answers how many press kits and upcoming shows a project has in the same query, and each list shows that many placeholders shaped like its real cards or rows. The cards themselves are unchanged. The artist search can't know its result count before it answers, so its results area keeps the placeholder's height instead./dashboardis unchanged (0.084 on a phone): nothing stored says which projects an account manages.The
getProjectlexicon changed: runpnpm lexicons:publishbefore deploying.How it was tested
Lighthouse before and after on mobile and desktop, median of 3: every changed page is at 0 to 0.001 CLS, and the public press-kits page's mobile performance went from 0.89 to 0.98. Screenshots at 390 and 1440 match the previous loaded pages. Tests cover the counts in the directory query and the service, the placeholder counts on the press-kits and project pages, and the Storybook loading stories. Each was broken once to confirm it fails. format, lint, check, test, Storybook, knip, coverage and
tools/policy.shpass.