Repository navigation
Preserve array bounds across exception regions - #613
Merged
dadhi merged 1 commit intoNov 10, 2026
Merged
Conversation
A try/finally in a later multidimensional array bound can clear earlier bounds from the evaluation stack and produce invalid IL. Record those bounds during collection and spill their evaluated values before constructing the array. The first bound alone does not require this spill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A try/finally in a later multidimensional array bound can clear earlier bounds from the evaluation stack and produce invalid IL. Record those bounds during collection and spill their evaluated values before constructing the array. The first bound alone does not require this spill.
Multidimensional bounds, ordered side effects, cleanup and failing bounds. Regressions use strict FEC compilation for both Standard and LightExpression.
Validation
Release solution build: zero warnings/errors.
Measurements
Current master
f1d2fb33→ this change, Release, Windows ARM64, .NET 8.0.28 / 10.0.9. Compilation uses prebuilt trees; runtime measures invocation through the same wrapper. Two fresh process rounds with reversed load order, seven samples per round, about 30 ms calibration, one logical CPU and tiered compilation disabled. Tables use the median of the two per-round medians.The controls below produce correct results on master for their measured inputs. Newly supported trees have no valid before/after execution comparison because master rejects them, produces incorrect results or emits invalid IL. Timings include machine and JIT/code-placement variation; the unchanged add control helps show that variation. These observations do not prove universal performance neutrality.
net8.0 results (master → change)
net10.0 results (master → change)
Emitted IL differs in these measured workloads: none.
No measured allocation increase above 0.1 B/op in these controls.